yaxunl added a comment.
@tra Originally we introduced the `__hip_pinned_shadow__` attribute to support
texture type. It ended up as a variable attribute for more generic usage.
However we got usability issue since users have to add this attribute whenever
they use texture type. I would like to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL364381: [HIP] Support attribute hip_pinned_shadow (authored
by yaxunl, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llv
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM. Thank you!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62738/new/
https://reviews.llvm.org/D62738
___
cfe-commits mailing list
cfe-com
yaxunl updated this revision to Diff 206504.
yaxunl retitled this revision from "[HIP] Support device_shadow variable" to
"[HIP] Support attribute hip_pinned_shadow".
yaxunl edited the summary of this revision.
yaxunl added a comment.
rename the attribute and make it HIP only.
CHANGES SINCE LAS
