[PATCH] D62839: [clangd] Index API and implementations for relations

nridge added a comment. Thanks for fixing that! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62839/new/ https://reviews.llvm.org/D62839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D62839: [clangd] Index API and implementations for relations

hintonda added a comment. This seems to have broken gcc 5.4 builds -- for example see http://lab.llvm.org:8011/builders/clang-cmake-armv7-lnt/builds/29/steps/build%20stage%201/logs/stdio. I believe the following patch should fix the problem: diff --git a/clang-tools-extra/clangd/index/FileInd

[PATCH] D62839: [clangd] Index API and implementations for relations

This revision was automatically updated to reflect the committed changes. Closed by commit rL363481: [clangd] Index API and implementations for relations (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D62839: [clangd] Index API and implementations for relations

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62839/new/ https://reviews.llvm.org/D62839 __

[PATCH] D62839: [clangd] Index API and implementations for relations

nridge updated this revision to Diff 204691. nridge marked 7 inline comments as done. nridge added a comment. Address latest review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62839/new/ https://reviews.llvm.org/D62839 Files: clang-to

[PATCH] D62839: [clangd] Index API and implementations for relations

nridge added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:244 llvm::function_ref Callback) const { trace::Span Tracer("Dex lookup"); for (const auto &ID : Req.IDs) { kadircet wrote: > could you revert these chang

[PATCH] D62839: [clangd] Index API and implementations for relations

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Index.h:77 +struct RelationsRequest { + SymbolID Subject; + index::SymbolRole Predicate; nridge wrote: > kadircet wrote: > > sorry for missing it in previous iteration. but this should a

[PATCH] D62839: [clangd] Index API and implementations for relations

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/index/Index.h:77 +struct RelationsRequest { + SymbolID Subject; + index::SymbolRole Predicate; kadircet wrote: > sorry for missing it in previous iterati

[PATCH] D62839: [clangd] Index API and implementations for relations

kadircet added a comment. LGTM, except the batch query support. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:97 + +SymbolSlab indexHeaderSymbols(ASTContext &AST, std::shared_ptr PP, + const CanonicalIncludes &Includes) { ---

[PATCH] D62839: [clangd] Index API and implementations for relations

nridge updated this revision to Diff 204189. nridge marked 9 inline comments as done. nridge added a comment. Address remaining review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62839/new/ https://reviews.llvm.org/D62839 Files: clang

[PATCH] D62839: [clangd] Index API and implementations for relations

nridge added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:250 Path, llvm::make_unique(std::move(Symbols)), - llvm::make_unique(), /*CountReferences=*/false); + llvm::make_unique(), llvm::make_unique(), + /*CountReferences=*/false

[PATCH] D62839: [clangd] Index API and implementations for relations

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:202 + for (const auto &RelationSlab : RelationSlabs) { +for (const auto &R : *RelationSlab) { + AllRelations.push_back(R); ---

[PATCH] D62839: [clangd] Index API and implementations for relations

nridge added inline comments. Comment at: clang-tools-extra/clangd/index/Index.h:107 + virtual void + relations(const SymbolID &Subject, index::SymbolRole Predicate, +llvm::function_ref Callback) const = 0; kadircet wrote: > We might need additional

[PATCH] D62839: [clangd] Index API and implementations for relations

nridge updated this revision to Diff 203495. nridge marked 16 inline comments as done. nridge added a comment. Addressed most review comments, also added some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62839/new/ https://reviews.llvm.org/D

[PATCH] D62839: [clangd] Index API and implementations for relations

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Background.cpp:293 + // This map is used to figure out where to store relations. + llvm::DenseMap IDsToFiles; for (const auto &Sym : *Index.Symbols) { nit: rename to `SymbolIDToFile`?

[PATCH] D62839: [clangd] Index API and implementations for relations

nridge added a comment. Ok, this is probably ready for a first round of review now. I know I should add new test cases to at least DexTests and BackgroundIndexTests, I'll do this in the next version of the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review