[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

dim abandoned this revision. dim added a comment. No longer needed after rC362328 and follow-ups. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62873/new/ https://reviews.llvm.org/D62873

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

hintonda added a comment. In D62873#1530197 , @Szelethus wrote: > I seem to have missed out on previous commits that moved analyzer plugins > around -- would you mind adding `[analyzer]` to the revision names that > affect the Static Analyzer? Many of us

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

Szelethus accepted this revision. Szelethus added a comment. I seem to have missed out on previous commits that moved analyzer plugins around -- would you mind adding `[analyzer]` to the revision names that affect the Static Analyzer? Many of us are automatically subscribed to such patches. In

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

hintonda added inline comments. Comment at: lib/Analysis/plugins/CMakeLists.txt:1 -if(LLVM_ENABLE_PLUGINS) +if(LLVM_ENABLE_PLUGINS AND CLANG_ENABLE_STATIC_ANALYZER) add_subdirectory(SampleAnalyzer) Szelethus wrote: > Is this file a thing? `lib/Analysis/plugins

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

Szelethus added inline comments. Comment at: lib/Analysis/plugins/CMakeLists.txt:1 -if(LLVM_ENABLE_PLUGINS) +if(LLVM_ENABLE_PLUGINS AND CLANG_ENABLE_STATIC_ANALYZER) add_subdirectory(SampleAnalyzer) Is this file a thing? `lib/Analysis/plugins/CMakeLists.txt`?

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

hintonda accepted this revision. hintonda added a comment. This revision is now accepted and ready to land. LGTM... Comment at: test/CMakeLists.txt:122 -if (CLANG_ENABLE_STATIC_ANALYZER) - if (LLVM_ENABLE_PLUGINS) -list(APPEND CLANG_TEST_DEPS - SampleAnalyzerPlugin

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

hintonda added a comment. In D62873#1529800 , @nathanchance wrote: > Thanks for the quick fix, looks good to me! Ah, sorry, just saw this. I just committed r362555 that addresses this. Repository: rC Clang CHANGES SINCE LAST ACTION https://revie

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

nathanchance added a comment. Thanks for the quick fix, looks good to me! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62873/new/ https://reviews.llvm.org/D62873 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

kristina added a comment. Experienced the same, updated my test build configuration to always force `CLANG_ENABLE_STATIC_ANALYZER` to On when building with tests. Maybe it's worth adding a warning about when Clang tests are being built? Repository: rC Clang CHANGES SINCE LAST ACTION https

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

dim created this revision. dim added reviewers: hintonda, dcoughlin, NoQ. Herald added subscribers: dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, mgorny. Herald added a project: clang. Attempting to build clang with CLANG_ENABLE_STATIC_ANALYZER=OFF fails after rC362328