[PATCH] D62883: [analyzer] Track terminator conditions on which a tracked expressions depends

2019-07-05 Thread Kristóf Umann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365207: [analyzer] Track terminator conditions on which a tracked expression depends (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D62883: [analyzer] Track terminator conditions on which a tracked expressions depends

2019-07-04 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. Accept². Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1824-1825 + // because of this, let's explain why we believe control reached this point. + // TODO: Shouldn't we track control dependencies of every

[PATCH] D62883: [analyzer] Track terminator conditions on which a tracked expressions depends

2019-07-04 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus updated this revision to Diff 208084. Szelethus marked 6 inline comments as done. Szelethus added a comment. - Add two more test cases when a "Returning value" note is meaningful, and one where it's not - Fix inlines! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62883/new/

[PATCH] D62883: [analyzer] Track terminator conditions on which a tracked expressions depends

2019-06-25 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus marked an inline comment as done. Szelethus added a comment. I usually do the final update right before commiting. There still are non-accepted dependencies, who knows what'll happen. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:157

[PATCH] D62883: [analyzer] Track terminator conditions on which a tracked expressions depends

2019-06-25 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Artem had some comments that are not marked as done, but LGTM! Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:157 + /// Conditions

[PATCH] D62883: [analyzer] Track terminator conditions on which a tracked expressions depends

2019-06-22 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D62883#1554514 , @Szelethus wrote: > In D62883#1554494 , @NoQ wrote: > > > It should be pretty easy to implement, just add your new visitor to the > > list of default visitors in

[PATCH] D62883: [analyzer] Track terminator conditions on which a tracked expressions depends

2019-06-21 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/test/Analysis/track-control-dependency-conditions.cpp:1-8 +// RUN: %clang_analyze_cc1 %s -verify -DTRACKING_CONDITIONS \ +// RUN: -analyzer-config track-conditions=true \ +// RUN:

[PATCH] D62883: [analyzer] Track terminator conditions on which a tracked expressions depends

2019-06-21 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Woohoo! Thanks for everything, this is the most fun I've had working on this project! Let's wait for @xazax.hun to have the final say. In D62883#1554494 , @NoQ wrote: > It should be pretty easy to implement, just add your new

[PATCH] D62883: [analyzer] Track terminator conditions on which a tracked expressions depends

2019-06-21 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. It should be pretty easy to implement, just add your new visitor to the list of default visitors in `findValidReport()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62883/new/ https://reviews.llvm.org/D62883

[PATCH] D62883: [analyzer] Track terminator conditions on which a tracked expressions depends

2019-06-21 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. Aha, ok, got it. I guess the official term is "error node" (where "error" means "warning"). Comment at: clang/test/Analysis/track-control-dependency-conditions.cpp:1-8 +// RUN: %clang_analyze_cc1 %s -verify

[PATCH] D62883: [analyzer] Track terminator conditions on which a tracked expressions depends

2019-06-21 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. In D62883#1554339 , @NoQ wrote: > In D62883#1553248 , @Szelethus wrote: > > > - Add a `TODO:` in `trackExpressionValue` about maybe tracking conditions > > to all bug locations, rather

[PATCH] D62883: [analyzer] Track terminator conditions on which a tracked expressions depends

2019-06-21 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D62883#1553248 , @Szelethus wrote: > - Add a `TODO:` in `trackExpressionValue` about maybe tracking conditions to > all bug locations, rather than only for tracked variables. What do you mean by "all bug locations"?