This revision was automatically updated to reflect the committed changes.
Closed by commit rL363510: [analyzer] Track indices of arrays (authored by
Szelethus, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.or
baloghadamsoftware accepted this revision.
baloghadamsoftware added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63080/new/
https://reviews.llvm.org/D63080
___
cfe-commits m
NoQ accepted this revision.
NoQ added a comment.
Great, thanks!!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63080/new/
https://reviews.llvm.org/D63080
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
Szelethus updated this revision to Diff 204888.
Szelethus added a comment.
One more test just for good measure, don't enable null fp suppression.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63080/new/
https://reviews.llvm.org/D63080
Files:
clang/lib/StaticAnalyzer/Core/BugReporterV
baloghadamsoftware requested changes to this revision.
baloghadamsoftware added inline comments.
This revision now requires changes to proceed.
Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1681
+trackExpressionValue(
+LVNode, Arr->getIdx(), report
NoQ added a comment.
Whoa, this looks like a much needed improvement, i'm glad that you found it!
Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1681
+trackExpressionValue(
+LVNode, Arr->getIdx(), report, EnableNullFPSuppression);
+
--
Szelethus created this revision.
Szelethus added reviewers: NoQ, dcoughlin, xazax.hun, rnkovacs,
baloghadamsoftware, Charusso.
Szelethus added a project: clang.
Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy,
mikhail.ramalho, a.sidorin, szepet, whisperity.
Observe the test
