[PATCH] D63108: [OpenMP] Add support for handling declare target to clause when unified memory is required

This revision was automatically updated to reflect the committed changes. Closed by commit rL363959: [OpenMP] Add support for handling declare target to clause when unified memory… (authored by gbercea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D63108: [OpenMP] Add support for handling declare target to clause when unified memory is required

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63108/new/ https://reviews.llvm.org/D63108 ___ cfe-commits

[PATCH] D63108: [OpenMP] Add support for handling declare target to clause when unified memory is required

gtbercea updated this revision to Diff 205839. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63108/new/ https://reviews.llvm.org/D63108 Files: lib/CodeGen/CGDeclCXX.cpp lib/CodeGen/CGExpr.cpp

[PATCH] D63108: [OpenMP] Add support for handling declare target to clause when unified memory is required

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:9227-9229 + } else if ((*Res == OMPDeclareTargetDeclAttr::MT_Link) || + (*Res == OMPDeclareTargetDeclAttr::MT_To && + HasRequiresUnifiedSharedMemory)) { Use

[PATCH] D63108: [OpenMP] Add support for handling declare target to clause when unified memory is required

gtbercea updated this revision to Diff 205825. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63108/new/ https://reviews.llvm.org/D63108 Files: lib/CodeGen/CGDeclCXX.cpp lib/CodeGen/CGExpr.cpp

[PATCH] D63108: [OpenMP] Add support for handling declare target to clause when unified memory is required

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2566-2569 + if (*Res == OMPDeclareTargetDeclAttr::MT_Link) +OS << CGM.getMangledName(GlobalDecl(VD)) << "_decl_tgt_link_ptr"; + else +OS << CGM.getMangledName(GlobalDecl(VD)) <<

[PATCH] D63108: [OpenMP] Add support for handling declare target to clause when unified memory is required

gtbercea added a comment. Still need to update the test but the rest of the code is updated. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63108/new/ https://reviews.llvm.org/D63108 ___ cfe-commits mailing list

[PATCH] D63108: [OpenMP] Add support for handling declare target to clause when unified memory is required

gtbercea updated this revision to Diff 205667. gtbercea marked an inline comment as done. gtbercea added a comment. - Merge MT_Link and MT_To with unified memory cases. - Transform switch into if statements. - Fix declare target attribute checks. Repository: rC Clang CHANGES SINCE LAST

[PATCH] D63108: [OpenMP] Add support for handling declare target to clause when unified memory is required

ABataev added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:2297-2319 +static Address emitDeclTargetToVarDeclLValue(CodeGenFunction , + const VarDecl *VD, QualType T) { + llvm::Optional Res = +

[PATCH] D63108: [OpenMP] Add support for handling declare target to clause when unified memory is required

ABataev added a comment. Will review it next week, when I'm back to work, need to think about it a little bit. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63108/new/ https://reviews.llvm.org/D63108 ___

[PATCH] D63108: [OpenMP] Add support for handling declare target to clause when unified memory is required

gtbercea added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63108/new/ https://reviews.llvm.org/D63108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63108: [OpenMP] Add support for handling declare target to clause when unified memory is required

gtbercea created this revision. gtbercea added reviewers: ABataev, AlexEichenberger, caomhin. Herald added subscribers: cfe-commits, jdoerfert, guansong. Herald added a project: clang. This patch adds support for the handling of the variables under the declare target to clause. The variables in