[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

leonardchan abandoned this revision. leonardchan added a comment. Replaced with D65110 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63174/new/ https://reviews.llvm.org/D63174

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

leonardchan added a comment. In D63174#1553096 , @craig.topper wrote: > I'm going to try to work on the X86 tests. Can we hold off on committing > those? Ok. For now I'll just commit the convergent.cl test separately. Repository: rG LLVM Github

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

craig.topper added a comment. I'm going to try to work on the X86 tests. Can we hold off on committing those? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63174/new/ https://reviews.llvm.org/D63174

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. Eh, this seems close enough now. I'd like a better approach for the x86 builtins, but no idea what it will end up being. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

leonardchan updated this revision to Diff 205727. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63174/new/ https://reviews.llvm.org/D63174 Files: clang/test/CodeGen/avx512-reduceMinMaxIntrin.c clang/test/CodeGen/avx512f-builtins.c

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

leonardchan added a comment. In D63174#1549601 , @chandlerc wrote: > OMG, I'm so sorry, I had no idea that the tests would explode like that... > Yeah, I don't think that's useful > > Maybe a better approach is to just explicitly run the code through

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

leonardchan updated this revision to Diff 205722. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63174/new/ https://reviews.llvm.org/D63174 Files: clang/test/CodeGen/avx512-reduceMinMaxIntrin.c clang/test/CodeGen/avx512f-builtins.c

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

leonardchan updated this revision to Diff 205707. Herald added subscribers: dexonsmith, steven_wu, javed.absar, mehdi_amini. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63174/new/ https://reviews.llvm.org/D63174 Files:

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

chandlerc added a comment. OMG, I'm so sorry, I had no idea that the tests would explode like that... Yeah, I don't think that's useful Maybe a better approach is to just explicitly run the code through `opt -passes=instsimplify` before handing it to FileCheck? That should produce almost

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

leonardchan added a comment. OK so I instead wrote a script that generated the tests for me since changing each individual case by hand was painful. All the `-cc1` tests now match, although I don't know any ways of simplifying the IR further to help reduce test size. I would definitely love to

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

leonardchan updated this revision to Diff 205496. leonardchan marked an inline comment as done. leonardchan added a reviewer: craig.topper. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63174/new/ https://reviews.llvm.org/D63174 Files:

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

leonardchan added a comment. For the avx tests, I don't suppose you know a simple way to generate these tests? They're about 10k lines long and it's taking a while to go through it by hand to replace the current IR checks with codegen for `-O1`. (Perhaps something along the lines of

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

leonardchan added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63174/new/ https://reviews.llvm.org/D63174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

chandlerc added a comment. This really confused me. We shouldn't be seeing this kind of difference in the new PM. But I think I figured it out. Both PMs have to run *some* inliner at -O0. This is because we need to inline `always_inline` functions. The new PM has a *super* simple (and fast

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

leonardchan created this revision. leonardchan added reviewers: chandlerc, echristo, phosek, serge-sans-paille. leonardchan added a project: clang. Herald added subscribers: dmgreen, Anastasia. With the new pass manager enabled by default, some tests produce slightly different IR from the legacy