sammccall added a comment.
Code gets shorter, tests get longer, very nice :-)
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63222/new/
https://reviews.llvm.org/D63222
___
cfe-commits mailing list
cfe-commits@lists.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL363253: [Clangd] Fixed clangd diagnostics priority (authored
by kadircet, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.
SureYeaah updated this revision to Diff 204494.
SureYeaah marked 2 inline comments as done.
SureYeaah added a comment.
Formatted code
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63222/new/
https://reviews.llvm.org/D63222
Files:
clang-tools-extr
SureYeaah updated this revision to Diff 204489.
SureYeaah marked 4 inline comments as done.
SureYeaah added a comment.
Simplified logic for diagnostics range.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63222/new/
https://reviews.llvm.org/D63222
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Also please make sure you've clang-formatted the code before you land this.
Comment at: clang-tools-extra/clangd/Diagnostics.cpp:94
}
llvm::Optional
SureYeaah updated this revision to Diff 204467.
SureYeaah added a comment.
Refactored code as pointed out by @kadircet
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63222/new/
https://reviews.llvm.org/D63222
Files:
clang-tools-extra/clangd/Diagno
kadircet added a comment.
Mostly LG, just a few re-orderings to make code more readable and get rid of
redundant Lexer calls.
Comment at: clang-tools-extra/clangd/Diagnostics.cpp:108
+ // Otherwise use zero width insertion range
auto R = Lexer::makeFileCharRange(CharSource
SureYeaah updated this revision to Diff 204351.
SureYeaah added a comment.
Remove extra newline
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63222/new/
https://reviews.llvm.org/D63222
Files:
clang-tools-extra/clangd/Diagnostics.cpp
clang-tools
SureYeaah created this revision.
SureYeaah added reviewers: sammccall, kadircet.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
- Fixed diagnostics where zero width inserted ranges were being used instead of
the whole token
- Ad
