This revision was automatically updated to reflect the committed changes.
Closed by commit rL363889: [clangd] Include the diagnosticss code when
comparing diagnostics (authored by nridge, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to
nridge updated this revision to Diff 205694.
nridge added a comment.
Add requested test case
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63316/new/
https://reviews.llvm.org/D63316
Files:
clang-tools-extra/clangd/Protocol.h
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM with one more test case request. Thanks!
Comment at: clang-tools-extra/clangd/test/fixits-duplication.test:44
+---
nridge updated this revision to Diff 204939.
nridge added a comment.
Revise fix and add test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63316/new/
https://reviews.llvm.org/D63316
Files:
clang-tools-extra/clangd/Protocol.h
nridge marked an inline comment as done.
nridge added a comment.
The fix actually broke another lit test, because in that test the client was
not sending the diagnostic's code back in the `codeAction` request, resulting
in a mismatch with the new comparison function.
I think a real client
kadircet added a comment.
Could you also add a lit test for the case you mentioned in the github issue?
You can find pointers in clang-tools-extra/clangd/test/diagnostics.test and
clang-tools-extra/clangd/test/fixits-codeaction.test
Comment at:
nridge created this revision.
nridge added a reviewer: kadircet.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
This fixes https://github.com/clangd/clangd/issues/60
Repository:
rG LLVM Github Monorepo
