[PATCH] D63666: [clang-doc] Add templates to HTML generator

2019-06-28 Thread Diego Astiazarán via Phabricator via cfe-commits
DiegoAstiazaran abandoned this revision. DiegoAstiazaran added a comment. D63857 replaces this revision. Nodes that represent each HTML tag are used instead of templates, it's easier to maintain. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63666/new/

[PATCH] D63666: [clang-doc] Add templates to HTML generator

2019-06-21 Thread Diego Astiazarán via Phabricator via cfe-commits
DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:313-314 + + + + Brief description. juliehockett wrote: > Emitting extra div/p here? Add a check in the comment generation bit to > ensure you're not em

[PATCH] D63666: [clang-doc] Add templates to HTML generator

2019-06-21 Thread Diego Astiazarán via Phabricator via cfe-commits
DiegoAstiazaran updated this revision to Diff 206103. DiegoAstiazaran marked 4 inline comments as done. DiegoAstiazaran added a comment. Add FIXME comments for llvm::SmallString to std::string transition. Add check so ParagraphComment template is not generated if its content would be empty. Fix t

[PATCH] D63666: [clang-doc] Add templates to HTML generator

2019-06-21 Thread Diego Astiazarán via Phabricator via cfe-commits
DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:307-308 + + + +f juliehockett wrote: > Emitting an extra div here? The first div is emitted by the Mai

[PATCH] D63666: [clang-doc] Add templates to HTML generator

2019-06-21 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:59 + Items += + applyHTMLTemplate(HTMLTemplates::BlockItem, M.str().str().c_str()); +} Put `FIXME: Transition Members from llvm::SmallString to std::st

[PATCH] D63666: [clang-doc] Add templates to HTML generator

2019-06-21 Thread Diego Astiazarán via Phabricator via cfe-commits
DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Herald added a subscriber: mgorny. Templates are added to create a stuctured HTML file. Commands in doxygen comments are still not han