[PATCH] D63678: Fix test Clang :: Driver/cl-response-file.c for Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rL364245: Fix test cl-response-file.c to work on all platforms including Windows/Solaris. (authored by dyung, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D63678: Fix test Clang :: Driver/cl-response-file.c for Solaris

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63678/new/ https://reviews.llvm.org/D63678 ___ cfe-commits mailing list

[PATCH] D63678: Fix test Clang :: Driver/cl-response-file.c for Solaris

rnk added a comment. In D63678#1554513 , @ro wrote: > Please have a look at what the autoconf manual has to say on echo vs. printf: Yikes, fair enough. I actually really wish lit had some support for the here-document pattern: cat

[PATCH] D63678: Fix test Clang :: Driver/cl-response-file.c for Solaris

ro added a comment. In D63678#1554508 , @rnk wrote: > I would almost prefer to XFAIL this on Solaris, I feel like the intent is > clearer with echo. Please have a look at what the autoconf manual has to say on echo vs. printf:

[PATCH] D63678: Fix test Clang :: Driver/cl-response-file.c for Solaris

rnk added a comment. I would almost prefer to XFAIL this on Solaris, I feel like the intent is clearer with echo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63678/new/ https://reviews.llvm.org/D63678 ___ cfe-commits mailing list

[PATCH] D63678: Fix test Clang :: Driver/cl-response-file.c for Solaris

dyung created this revision. dyung added reviewers: ro, rnk, jkorous. dyung added a project: clang. Herald added subscribers: dexonsmith, fedor.sergeev. This is a follow up to D63600 that attempts to fix the test to work on all platforms including Windows (which