This revision was automatically updated to reflect the committed changes.
Closed by commit rL364664: [ODRHash] Fix null pointer dereference for ObjC
selectors with empty slots. (authored by vsapsai, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed
rtrieu accepted this revision.
rtrieu added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63789/new/
https://reviews.llvm.org/D63789
vsapsai updated this revision to Diff 206992.
vsapsai added a comment.
Herald added a project: clang.
- Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63789/new/
https://reviews.llvm.org/D63789
Files:
rtrieu added inline comments.
Comment at: clang/lib/AST/ODRHash.cpp:73
AddBoolean(S.isUnarySelector());
unsigned NumArgs = S.getNumArgs();
for (unsigned i = 0; i < NumArgs; ++i) {
vsapsai wrote:
> rtrieu wrote:
> > There's actually a second bug
vsapsai added inline comments.
Comment at: clang/lib/AST/ODRHash.cpp:73
AddBoolean(S.isUnarySelector());
unsigned NumArgs = S.getNumArgs();
for (unsigned i = 0; i < NumArgs; ++i) {
rtrieu wrote:
> There's actually a second bug here as well. When
rtrieu added inline comments.
Comment at: clang/lib/AST/ODRHash.cpp:73
AddBoolean(S.isUnarySelector());
unsigned NumArgs = S.getNumArgs();
for (unsigned i = 0; i < NumArgs; ++i) {
There's actually a second bug here as well. When processing an
vsapsai created this revision.
vsapsai added a reviewer: rtrieu.
Herald added subscribers: dexonsmith, jkorous.
Because `Selector::getIdentifierInfoForSlot` returns NULL if a slot has
no corresponding identifier, use `Selector::getNameForSlot` instead.
rdar://problem/51615164
