[PATCH] D63845: [WIP] Create a clang attribute that lets users specify LLVM attributes

jdoerfert added a comment. Herald added a subscriber: dexonsmith. ping, could we come up with a design for this functionality? Comment at: llvm/lib/IR/Attributes.cpp:522 + .Default(Attribute::None); +} + can't we create this via tablegen? Repository: r

[PATCH] D63845: [WIP] Create a clang attribute that lets users specify LLVM attributes

aaron.ballman added a comment. In D63845#1571855 , @jdoerfert wrote: > I think we should postpone a detailed discussion until we are ready to send > an RFC on this. Nevertheless, I inlined some responses below. > > In D63845#1570639

[PATCH] D63845: [WIP] Create a clang attribute that lets users specify LLVM attributes

jdoerfert added a comment. I think we should postpone a detailed discussion until we are ready to send an RFC on this. Nevertheless, I inlined some responses below. In D63845#1570639 , @aaron.ballman wrote: > In D63845#1566987

[PATCH] D63845: [WIP] Create a clang attribute that lets users specify LLVM attributes

aaron.ballman added a comment. In D63845#1566987 , @jdoerfert wrote: > In D63845#1561983 , @lebedev.ri > wrote: > > > In D63845#1561793 , @jdoerfert > > wrote: > > > > > In

[PATCH] D63845: [WIP] Create a clang attribute that lets users specify LLVM attributes

jdoerfert added a comment. In D63845#1561983 , @lebedev.ri wrote: > In D63845#1561793 , @jdoerfert wrote: > > > In D63845#1560605 , @aaron.ballman > > wrote: > > > > > In D6

[PATCH] D63845: [WIP] Create a clang attribute that lets users specify LLVM attributes

aaron.ballman added a comment. In D63845#1562006 , @wsmoses wrote: > Just to preface these comments -- this is work in progress and not intended > to go in as is / without discussion (but happily is indeed inviting > discussion). Fantastic! > In D6384

[PATCH] D63845: [WIP] Create a clang attribute that lets users specify LLVM attributes

wsmoses added a comment. Just to preface these comments -- this is work in progress and not intended to go in as is / without discussion (but happily is indeed inviting discussion). In D63845#1561983 , @lebedev.ri wrote: > In D63845#1561793

[PATCH] D63845: [WIP] Create a clang attribute that lets users specify LLVM attributes

lebedev.ri added a comment. In D63845#1561793 , @jdoerfert wrote: > In D63845#1560605 , @aaron.ballman > wrote: > > > In D63845#1559995 , @lebedev.ri > > wrote: > > > > > W

[PATCH] D63845: [WIP] Create a clang attribute that lets users specify LLVM attributes

jdoerfert added a comment. In D63845#1560605 , @aaron.ballman wrote: > In D63845#1559995 , @lebedev.ri > wrote: > > > What's the target use-case here? What can't be solved with normal > > attributes? > With "no

[PATCH] D63845: [WIP] Create a clang attribute that lets users specify LLVM attributes

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. In D63845#1559995 , @lebedev.ri wrote: > What's the target use-case here? What can't be solved with normal attributes? > I wonder if this should go to cfe+llvm -dev lists first,

[PATCH] D63845: [WIP] Create a clang attribute that lets users specify LLVM attributes

lebedev.ri added a comment. What's the target use-case here? What can't be solved with normal attributes? I wonder if this should go to cfe+llvm -dev lists first, it's kinda intrusive. I also wonder if all these should cause a clang diagnostic, at least under `-Wall`. How is versioning expected t

[PATCH] D63845: [WIP] Create a clang attribute that lets users specify LLVM attributes

jdoerfert added a comment. Please add full context to the patches (http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface) Also, some general comments inlined. Comment at: clang/include/clang/Basic/Attr.td:1652 + let Args = [StringArgument<"AttrName">

[PATCH] D63845: [WIP] Create a clang attribute that lets users specify LLVM attributes

wsmoses updated this revision to Diff 206751. wsmoses added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Actually upload full patch so far (and not just the last commit). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D63845: [WIP] Create a clang attribute that lets users specify LLVM attributes

wsmoses created this revision. wsmoses added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. This (work in progress) diff adds three new attributes to clang (__attribute__((LLVMFN(string))), __attribute__((LLVMARG(paramidx, string))), __attribute__((