[PATCH] D63876: [OpenCL] Define CLK_NULL_EVENT without cast

This revision was automatically updated to reflect the committed changes. Closed by commit rL366546: [OpenCL] Define CLK_NULL_EVENT without cast (authored by svenvh, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[PATCH] D63876: [OpenCL] Define CLK_NULL_EVENT without cast

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! If you like you can also change reserve_id_t. :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63876/new/ https://reviews.llvm.org/D63876

[PATCH] D63876: [OpenCL] Define CLK_NULL_EVENT without cast

svenvh added a comment. In D63876#1565004 , @Anastasia wrote: > btw, there seems to be the same issue with `reserve_id_t`? Yes, `CLK_NULL_RESERVE_ID` has the same cast. I don't have any use case that is affected by it at the moment, so I left it out of

[PATCH] D63876: [OpenCL] Define CLK_NULL_EVENT without cast

Anastasia added a comment. btw, there seems to be the same issue with `reserve_id_t`? Comment at: lib/Headers/opencl-c-base.h:416 #define CLK_NULL_QUEUE 0 -#define CLK_NULL_EVENT (__builtin_astype(((void*)(__SIZE_MAX__)), clk_event_t)) +#define CLK

[PATCH] D63876: [OpenCL] Define CLK_NULL_EVENT without cast

svenvh created this revision. svenvh added reviewers: Anastasia, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. Defining CLK_NULL_EVENT with a `(void*)` cast has the (unintended?) side-effect that the address space will be fixed (as generic in OpenCL 2.0 mode). The