[PATCH] D64018: [clangd] Store hash of command line in index shards.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365121: [clangd] Store hash of command line in index shards. (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[PATCH] D64018: [clangd] Store hash of command line in index shards.

kadircet updated this revision to Diff 207721. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64018/new/ https://reviews.llvm.org/D64018 Files: clang-tools-ex

[PATCH] D64018: [clangd] Store hash of command line in index shards.

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:531 +for (llvm::StringRef C : Cmd.CommandLine) + Result.Cmd->CommandLine.emplace_back(C.str()); + } nit: push_back, or emplac

[PATCH] D64018: [clangd] Store hash of command line in index shards.

kadircet updated this revision to Diff 207578. kadircet marked 3 inline comments as done. kadircet added a comment. - Use an InternedCompileCommand struct rather than a pack of StringRefs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64018/new/ ht

[PATCH] D64018: [clangd] Store hash of command line in index shards.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:418 + +tooling::CompileCommand +readCompileCommand(Reader CmdReader, llvm::ArrayRef Strings) {

[PATCH] D64018: [clangd] Store hash of command line in index shards.

sammccall added a comment. Still LG Comment at: clang-tools-extra/clangd/index/Serialization.h:48 llvm::Optional Sources; + llvm::Optional Cmd; }; Need to document that this contains only Directory and CommandLine (or use another struct) Repository: r

[PATCH] D64018: [clangd] Store hash of command line in index shards.

kadircet updated this revision to Diff 207489. kadircet added a comment. - Store Cmdline itself instead of hash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64018/new/ https://reviews.llvm.org/D64018 Files: clang-tools-extra/clangd/index/Backgr

[PATCH] D64018: [clangd] Store hash of command line in index shards.

kadircet added a comment. In D64018#1566085 , @sammccall wrote: > This makes sense but is hard to debug - is there a reason we don't just store > (the relevant parts of) the actual compile command? Size? Yes I had the size in mind, also didn't see any u

[PATCH] D64018: [clangd] Store hash of command line in index shards.

sammccall added a comment. This makes sense but is hard to debug - is there a reason we don't just store (the relevant parts of) the actual compile command? Size? Comment at: clang-tools-extra/clangd/index/Background.cpp:434 SPAN_ATTACH(Tracer, "file", Cmd.Filename); + siz

[PATCH] D64018: [clangd] Store hash of command line in index shards.

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is to enable cache invalidation when command line flags changes. Repository: rG LLVM Github Monorepo htt