[PATCH] D64044: [clang][Driver][ARM] NFC: Remove unused function parameter

[Phabricator via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL364895: [clang][Driver][ARM] NFC: Remove unused function 
parameter (authored by alelab01, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Changed prior to commit:
  https://reviews.llvm.org/D64044?vs=207421=207492#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64044/new/

https://reviews.llvm.org/D64044

Files:
  cfe/trunk/lib/Driver/ToolChains/Arch/ARM.cpp


Index: cfe/trunk/lib/Driver/ToolChains/Arch/ARM.cpp
===
--- cfe/trunk/lib/Driver/ToolChains/Arch/ARM.cpp
+++ cfe/trunk/lib/Driver/ToolChains/Arch/ARM.cpp
@@ -100,7 +100,6 @@
 static void checkARMArchName(const Driver , const Arg *A, const ArgList 
,
  llvm::StringRef ArchName, llvm::StringRef CPUName,
  std::vector ,
- std::vector ,
  const llvm::Triple ) {
   std::pair Split = ArchName.split("+");
 
@@ -108,7 +107,7 @@
   llvm::ARM::ArchKind ArchKind = llvm::ARM::parseArch(MArch);
   if (ArchKind == llvm::ARM::ArchKind::INVALID ||
   (Split.second.size() && !DecodeARMFeatures(
-D, Split.second, CPUName, ArchKind, ExtensionFeatures)))
+D, Split.second, CPUName, ArchKind, Features)))
 D.Diag(clang::diag::err_drv_clang_unsupported) << A->getAsString(Args);
 }
 
@@ -116,7 +115,6 @@
 static void checkARMCPUName(const Driver , const Arg *A, const ArgList ,
 llvm::StringRef CPUName, llvm::StringRef ArchName,
 std::vector ,
-std::vector ,
 const llvm::Triple ) {
   std::pair Split = CPUName.split("+");
 
@@ -125,7 +123,7 @@
 arm::getLLVMArchKindForARM(CPU, ArchName, Triple);
   if (ArchKind == llvm::ARM::ArchKind::INVALID ||
   (Split.second.size() && !DecodeARMFeatures(
-D, Split.second, CPU, ArchKind, ExtensionFeatures)))
+D, Split.second, CPU, ArchKind, Features)))
 D.Diag(clang::diag::err_drv_clang_unsupported) << A->getAsString(Args);
 }
 
@@ -361,13 +359,13 @@
   << ArchArg->getAsString(Args);
 ArchName = StringRef(WaArch->getValue()).substr(7);
 checkARMArchName(D, WaArch, Args, ArchName, CPUName,
- Features, ExtensionFeatures, Triple);
+ ExtensionFeatures, Triple);
 // FIXME: Set Arch.
 D.Diag(clang::diag::warn_drv_unused_argument) << WaArch->getAsString(Args);
   } else if (ArchArg) {
 ArchName = ArchArg->getValue();
 checkARMArchName(D, ArchArg, Args, ArchName, CPUName,
- Features, ExtensionFeatures, Triple);
+ ExtensionFeatures, Triple);
   }
 
   // Add CPU features for generic CPUs
@@ -383,7 +381,7 @@
 
   if (CPUArg)
 checkARMCPUName(D, CPUArg, Args, CPUName, ArchName,
-Features, ExtensionFeatures, Triple);
+ExtensionFeatures, Triple);
   // Honor -mfpu=. ClangAs gives preference to -Wa,-mfpu=.
   const Arg *FPUArg = Args.getLastArg(options::OPT_mfpu_EQ);
   if (WaFPU) {


Index: cfe/trunk/lib/Driver/ToolChains/Arch/ARM.cpp
===
--- cfe/trunk/lib/Driver/ToolChains/Arch/ARM.cpp
+++ cfe/trunk/lib/Driver/ToolChains/Arch/ARM.cpp
@@ -100,7 +100,6 @@
 static void checkARMArchName(const Driver , const Arg *A, const ArgList ,
  llvm::StringRef ArchName, llvm::StringRef CPUName,
  std::vector ,
- std::vector ,
  const llvm::Triple ) {
   std::pair Split = ArchName.split("+");
 
@@ -108,7 +107,7 @@
   llvm::ARM::ArchKind ArchKind = llvm::ARM::parseArch(MArch);
   if (ArchKind == llvm::ARM::ArchKind::INVALID ||
   (Split.second.size() && !DecodeARMFeatures(
-D, Split.second, CPUName, ArchKind, ExtensionFeatures)))
+D, Split.second, CPUName, ArchKind, Features)))
 D.Diag(clang::diag::err_drv_clang_unsupported) << A->getAsString(Args);
 }
 
@@ -116,7 +115,6 @@
 static void checkARMCPUName(const Driver , const Arg *A, const ArgList ,
 llvm::StringRef CPUName, llvm::StringRef ArchName,
 std::vector ,
-std::vector ,
 const llvm::Triple ) {
   std::pair Split = CPUName.split("+");
 
@@ -125,7 +123,7 @@
 arm::getLLVMArchKindForARM(CPU, ArchName, Triple);
   if (ArchKind == llvm::ARM::ArchKind::INVALID ||
   (Split.second.size() && !DecodeARMFeatures(
-D, Split.second, CPU, ArchKind, ExtensionFeatures)))
+D, Split.second, CPU, ArchKind, Features)))
 D.Diag(clang::diag::err_drv_clang_unsupported) << A->getAsString(Args);
 }
 
@@ -361,13 +359,13 @@
   << 

[PATCH] D64044: [clang][Driver][ARM] NFC: Remove unused function parameter

[Alexandros Lamprineas via Phabricator via cfe-commits]

labrinea created this revision.
labrinea added reviewers: ostannard, simon_tatham, cfe-commits.
Herald added subscribers: kristof.beyls, javed.absar.
Herald added a project: clang.

Removes a vector reference that was added by D62998 
, since the preexisting function parameter is 
sufficient.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D64044

Files:
  clang/lib/Driver/ToolChains/Arch/ARM.cpp


Index: clang/lib/Driver/ToolChains/Arch/ARM.cpp
===
--- clang/lib/Driver/ToolChains/Arch/ARM.cpp
+++ clang/lib/Driver/ToolChains/Arch/ARM.cpp
@@ -100,7 +100,6 @@
 static void checkARMArchName(const Driver , const Arg *A, const ArgList 
,
  llvm::StringRef ArchName, llvm::StringRef CPUName,
  std::vector ,
- std::vector ,
  const llvm::Triple ) {
   std::pair Split = ArchName.split("+");
 
@@ -108,7 +107,7 @@
   llvm::ARM::ArchKind ArchKind = llvm::ARM::parseArch(MArch);
   if (ArchKind == llvm::ARM::ArchKind::INVALID ||
   (Split.second.size() && !DecodeARMFeatures(
-D, Split.second, CPUName, ArchKind, ExtensionFeatures)))
+D, Split.second, CPUName, ArchKind, Features)))
 D.Diag(clang::diag::err_drv_clang_unsupported) << A->getAsString(Args);
 }
 
@@ -116,7 +115,6 @@
 static void checkARMCPUName(const Driver , const Arg *A, const ArgList ,
 llvm::StringRef CPUName, llvm::StringRef ArchName,
 std::vector ,
-std::vector ,
 const llvm::Triple ) {
   std::pair Split = CPUName.split("+");
 
@@ -125,7 +123,7 @@
 arm::getLLVMArchKindForARM(CPU, ArchName, Triple);
   if (ArchKind == llvm::ARM::ArchKind::INVALID ||
   (Split.second.size() && !DecodeARMFeatures(
-D, Split.second, CPU, ArchKind, ExtensionFeatures)))
+D, Split.second, CPU, ArchKind, Features)))
 D.Diag(clang::diag::err_drv_clang_unsupported) << A->getAsString(Args);
 }
 
@@ -361,13 +359,13 @@
   << ArchArg->getAsString(Args);
 ArchName = StringRef(WaArch->getValue()).substr(7);
 checkARMArchName(D, WaArch, Args, ArchName, CPUName,
- Features, ExtensionFeatures, Triple);
+ ExtensionFeatures, Triple);
 // FIXME: Set Arch.
 D.Diag(clang::diag::warn_drv_unused_argument) << WaArch->getAsString(Args);
   } else if (ArchArg) {
 ArchName = ArchArg->getValue();
 checkARMArchName(D, ArchArg, Args, ArchName, CPUName,
- Features, ExtensionFeatures, Triple);
+ ExtensionFeatures, Triple);
   }
 
   // Add CPU features for generic CPUs
@@ -383,7 +381,7 @@
 
   if (CPUArg)
 checkARMCPUName(D, CPUArg, Args, CPUName, ArchName,
-Features, ExtensionFeatures, Triple);
+ExtensionFeatures, Triple);
   // Honor -mfpu=. ClangAs gives preference to -Wa,-mfpu=.
   const Arg *FPUArg = Args.getLastArg(options::OPT_mfpu_EQ);
   if (WaFPU) {


Index: clang/lib/Driver/ToolChains/Arch/ARM.cpp
===
--- clang/lib/Driver/ToolChains/Arch/ARM.cpp
+++ clang/lib/Driver/ToolChains/Arch/ARM.cpp
@@ -100,7 +100,6 @@
 static void checkARMArchName(const Driver , const Arg *A, const ArgList ,
  llvm::StringRef ArchName, llvm::StringRef CPUName,
  std::vector ,
- std::vector ,
  const llvm::Triple ) {
   std::pair Split = ArchName.split("+");
 
@@ -108,7 +107,7 @@
   llvm::ARM::ArchKind ArchKind = llvm::ARM::parseArch(MArch);
   if (ArchKind == llvm::ARM::ArchKind::INVALID ||
   (Split.second.size() && !DecodeARMFeatures(
-D, Split.second, CPUName, ArchKind, ExtensionFeatures)))
+D, Split.second, CPUName, ArchKind, Features)))
 D.Diag(clang::diag::err_drv_clang_unsupported) << A->getAsString(Args);
 }
 
@@ -116,7 +115,6 @@
 static void checkARMCPUName(const Driver , const Arg *A, const ArgList ,
 llvm::StringRef CPUName, llvm::StringRef ArchName,
 std::vector ,
-std::vector ,
 const llvm::Triple ) {
   std::pair Split = CPUName.split("+");
 
@@ -125,7 +123,7 @@
 arm::getLLVMArchKindForARM(CPU, ArchName, Triple);
   if (ArchKind == llvm::ARM::ArchKind::INVALID ||
   (Split.second.size() && !DecodeARMFeatures(
-D, Split.second, CPU, ArchKind, ExtensionFeatures)))
+D, Split.second, CPU, ArchKind, Features)))
 D.Diag(clang::diag::err_drv_clang_unsupported) << A->getAsString(Args);
 }
 
@@ -361,13 +359,13 @@
   << ArchArg->getAsString(Args);
 ArchName = StringRef(WaArch->getValue()).substr(7);
 checkARMArchName(D, WaArch,