This revision was automatically updated to reflect the committed changes.
Closed by commit rL365315: [ASTImporter] Fix import of lambda in function param
(authored by martong, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https:/
martong updated this revision to Diff 207776.
martong marked an inline comment as done.
martong added a comment.
- 'the ' -> 'the '
- Use std::distance()
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64073/new/
https://reviews.llvm.org/D64073
Fil
martong marked 3 inline comments as done.
martong added a comment.
Thanks for the review Alexei!
Comment at: clang/unittests/AST/ASTImporterTest.cpp:5103
+ // count.
+ for (auto &D : ToL->decls()) {
+(void)D;
a_sidorin wrote:
> Can we use std::distance in
a_sidorin added a comment.
Hello Gabor,
There is an inline question about tests; other code looks fine.
Comment at: clang/lib/AST/ASTImporter.cpp:1713
+// In case of lambdas, the class already has a definition ptr set, but
+// the contained decls are not import
martong created this revision.
martong added a reviewer: a_sidorin.
Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs.
Herald added a reviewer: a.sidorin.
Herald added a reviewer: shafik.
Herald added a project: clang.
The current import implementation fails to import t
