[PATCH] D64075: [ASTImporter] Fix structural eq of lambdas

martong added a comment. Jenkins looks okay: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/31160/ .The build is red but the the previous run has the very same failing test case: expression_command/weak_symbols/TestWeakSymbols.py Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D64075: [ASTImporter] Fix structural eq of lambdas

This revision was automatically updated to reflect the committed changes. Closed by commit rL366332: [ASTImporter] Fix structural eq of lambdas (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64075: [ASTImporter] Fix structural eq of lambdas

martong added a comment. @shafik I've been looking for any lldb regression in our Mac machine, could not find any. Now I am looking at http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64075: [ASTImporter] Fix structural eq of lambdas

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Hello Gabor, This patch looks good to me. Regarding the related patch: can we use getLambdaManglingNumber() for the comparison? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D64075: [ASTImporter] Fix structural eq of lambdas

martong added a comment. In D64075#1572676 , @a_sidorin wrote: > Hi Gabor, > The patch looks good, but it looks to me that it has a relation to > https://reviews.llvm.org/D64078 that is kind of questionable to me. Let's > delay landing this patch until

[PATCH] D64075: [ASTImporter] Fix structural eq of lambdas

martong updated this revision to Diff 208727. martong added a comment. Herald added a reviewer: shafik. - Add test which crashes in baseline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64075/new/ https://reviews.llvm.org/D64075 Files:

[PATCH] D64075: [ASTImporter] Fix structural eq of lambdas

a_sidorin added a comment. Hi Gabor, The patch looks good, but it looks to me that it has a relation to https://reviews.llvm.org/D64078 that is kind of questionable to me. Let's delay landing this patch until the fix direction is clear. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D64075: [ASTImporter] Fix structural eq of lambdas

martong updated this revision to Diff 207774. martong marked an inline comment as done. martong added a comment. - Add check for isLambda() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64075/new/ https://reviews.llvm.org/D64075 Files:

[PATCH] D64075: [ASTImporter] Fix structural eq of lambdas

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:1182 + if (D1CXX->isLambda()) { +if (!D2CXX->isLambda()) a_sidorin wrote: > Should we return false if

[PATCH] D64075: [ASTImporter] Fix structural eq of lambdas

a_sidorin added a comment. Hello Gabor, This looks mostly good but I have a question inline. Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:1182 + if (D1CXX->isLambda()) { +if (!D2CXX->isLambda()) Should we return false if

[PATCH] D64075: [ASTImporter] Fix structural eq of lambdas

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. The structural equivalence check reported false eq between lambda classes with