plotfi updated this revision to Diff 211651.
plotfi marked an inline comment as done.
plotfi added a comment.
Removing 'A'
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64098/new/
https://reviews.llvm.org/D64098
Files:
clang/include/clang/Driver
plotfi added a comment.
This was a mistake. Updated the Wrong diff.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64098/new/
https://reviews.llvm.org/D64098
___
cfe-commits mailing list
cfe-commits@lis
This revision was automatically updated to reflect the committed changes.
Closed by commit rL366761: [NFC][clang] Refactor
getCompilationPhases()+Types.def step 1. (authored by zer0, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: clang/lib/Driver/Types.cpp:303
+ // Types.def is correct. Everything above this comment will be removed
+ // in a subsequent NFC
plotfi marked 2 inline comments as done.
plotfi added inline comments.
Comment at: clang/lib/Driver/Types.cpp:305
+ P.clear();
+ for (auto Phase : getInfo(Id).Phases)
+P.push_back(Phase);
aaron.ballman wrote:
> plotfi wrote:
> > aaron.ballman wrote:
> > > C
plotfi updated this revision to Diff 210696.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64098/new/
https://reviews.llvm.org/D64098
Files:
clang/include/clang/Driver/Types.def
clang/include/clang/Driver/Types.h
clang/lib/Driver/Driver.cpp
aaron.ballman added inline comments.
Comment at: clang/lib/Driver/Types.cpp:305
+ P.clear();
+ for (auto Phase : getInfo(Id).Phases)
+P.push_back(Phase);
plotfi wrote:
> aaron.ballman wrote:
> > Can't you use the local `Phases` object instead of calling `ge
plotfi updated this revision to Diff 210609.
plotfi added a comment.
Update.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64098/new/
https://reviews.llvm.org/D64098
Files:
clang/include/clang/Driver/Types.def
clang/include/clang/Driver/Types.
plotfi marked an inline comment as done.
plotfi added inline comments.
Comment at: clang/lib/Driver/Types.cpp:305
+ P.clear();
+ for (auto Phase : getInfo(Id).Phases)
+P.push_back(Phase);
aaron.ballman wrote:
> Can't you use the local `Phases` object instea
aaron.ballman added inline comments.
Comment at: clang/lib/Driver/Types.cpp:305
+ P.clear();
+ for (auto Phase : getInfo(Id).Phases)
+P.push_back(Phase);
Can't you use the local `Phases` object instead of calling `getInfo()` again?
This seems like it wants
plotfi updated this revision to Diff 210431.
plotfi marked 10 inline comments as done.
plotfi added a comment.
Updated to address @aaron.ballman 's feedback
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64098/new/
https://reviews.llvm.org/D64098
F
plotfi added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:2217
public:
-typedef llvm::SmallVector PhasesTy;
+typedef const std::vector PhasesTy;
aaron.ballman wrote:
> Why are you changing this to an STL type?
I changed it because it didn
aaron.ballman added inline comments.
Comment at: clang/include/clang/Driver/Types.h:100
/// done for type 'Id'.
- void getCompilationPhases(
-ID Id,
-llvm::SmallVectorImpl &Phases);
+ const std::vector getCompilationPhases(ID Id);
Please drop the t
plotfi added a comment.
@aaron.ballman Any thoughts on this?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64098/new/
https://reviews.llvm.org/D64098
___
cfe-commits mailing list
cfe-commits@lists.llvm
plotfi updated this revision to Diff 207659.
plotfi marked 4 inline comments as done.
plotfi added a comment.
Update diff based on @compnerd's feedback
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64098/new/
https://reviews.llvm.org/D64098
Files:
compnerd added inline comments.
Comment at: clang/lib/Driver/Types.cpp:29
+ { NAME, FLAGS, TEMP_SUFFIX, TY_##PP_TYPE, PHASES, },
+#define PHASES llvm::SmallVector
#include "clang/Driver/Types.def"
I think that we can abuse the preprocessor a bit and get somethi
compnerd added a comment.
The explicit list I think is way better for readability, this is a nice
starting point for cleaning this up.
Comment at: clang/include/clang/Driver/Types.def:18
// TYPE(NAME, ID, PP_TYPE, TEMP_SUFFIX, FLAGS)
Please update the com
plotfi created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
plotfi added a reviewer: compnerd.
Simplifying the phases generation process, first by copying the phases info
into the Table.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D64
18 matches
Mail list logo
