[PATCH] D64164: [clang][ARM] Fix msvc arm{64} builtins to use int on LLP64 systems.

rnk accepted this revision. rnk added a comment. Please check the commit message: > [clang][ARM] Fix msvc arm{64} builtins to use int on LLP64 systems. I think you mean "use int on LP64 systems", since long is 32-bits on LLP64, right? Otherwise, sounds good. Repository: rC Clang CHANGES S

[PATCH] D64164: [clang][ARM] Fix msvc arm{64} builtins to use int on LLP64 systems.

Bigcheese added a comment. In D64164#1569442 , @efriedma wrote: > Do the changes to BuiltinsARM.def have any practical effect? long should be > 32 bits on all 32-bit ARM targets. I don't think they do right now. I updated them there as that's what the

[PATCH] D64164: [clang][ARM] Fix msvc arm{64} builtins to use int on LLP64 systems.

efriedma added a comment. Do the changes to BuiltinsARM.def have any practical effect? long should be 32 bits on all 32-bit ARM targets. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64164/new/ https://reviews.llvm.org/D64164

[PATCH] D64164: [clang][ARM] Fix msvc arm{64} builtins to use int on LLP64 systems.

jfb accepted this revision. jfb added inline comments. This revision is now accepted and ready to land. Comment at: test/CodeGen/ms-intrinsics-other.c:212 + return _InterlockedAdd(Addend, Value); +} + Looks like only `cmpxchg` preserves `volatile`? That's not yo

[PATCH] D64164: [clang][ARM] Fix msvc arm{64} builtins to use int on LLP64 systems.

Bigcheese created this revision. Bigcheese added reviewers: bruno, rnk, bkelley. Herald added subscribers: kristina, jfb, dexonsmith, kristof.beyls, javed.absar. Herald added a project: clang. The `InterlockedX_{acq,nf,rel}` functions deal with 32 bits which is long on MSVC, but int on most other