This revision was automatically updated to reflect the committed changes.
Closed by commit rL365298: [AArch64] Fix vsqadd scalar intrinsics operands
(authored by dnsampaio, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
john.brawn accepted this revision.
john.brawn added a comment.
This revision is now accepted and ready to land.
LGTM, with a couple of nitpicks.
> The existing unsigned argument can cause faulty code as float to unsigned
> conversion is undefined,
> which llvm/clang optimizes away.
It's
dnsampaio created this revision.
dnsampaio added a reviewer: LukeCheeseman.
Herald added subscribers: cfe-commits, kristof.beyls, javed.absar.
Herald added a project: clang.
Change the vsqadd scalar instrinsics to have the second argument as signed
values, not unsigned,
accordingly to
