[PATCH] D64271: [analyzer] Don't track the right hand side of the last store for conditions

Szelethus added a comment. In D64271#1576872 , @NoQ wrote: > I'd rather not abandon this patch, because it looks like a strict improvement > over the lack of condition tracking, and it might as well still be an > improvement over "zealous" condition trac

[PATCH] D64271: [analyzer] Don't track the right hand side of the last store for conditions

NoQ added a comment. I'd rather not abandon this patch, because it looks like a strict improvement over the lack of condition tracking, and it might as well still be an improvement over "zealous" condition tracking, as my counterexample is fairly artificial. It indicates that a slightly more so

[PATCH] D64271: [analyzer] Don't track the right hand side of the last store for conditions

Szelethus abandoned this revision. Szelethus added a comment. You're right. If condition tracking only adds necessary information anyways, this shouldn't hurt that much anyways. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64271/new/ https://revi

[PATCH] D64271: [analyzer] Don't track the right hand side of the last store for conditions

NoQ added a comment. Consider: int flag; bool coin(); void foo() { flag = coin(); } void test() { int *x = 0; int local_flag; flag = 1; foo(); local_flag = flag; if (local_flag) x = new int; foo(); local_flag = flag; if (local_fl

[PATCH] D64271: [analyzer] Don't track the right hand side of the last store for conditions

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, rnkovacs, Charusso, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Szelethus added a