[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

This revision was automatically updated to reflect the committed changes. Closed by commit rL367428: [AArch64] Add support for Transactional Memory Extension (TME) (authored by chill, committed by ). Changed prior to commit: https://reviews.llvm.org/D64416?vs=212332=212559#toc Repository:

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

chill updated this revision to Diff 212332. chill added a comment. Rebase on top of master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64416/new/ https://reviews.llvm.org/D64416 Files: clang/include/clang/Basic/BuiltinsAArch64.def clang/lib/Basic/Targets/AArch64.cpp

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

chill added a comment. If there are no objections, I'll go ahead with committing that Soon(tm) on the basis of previous acceptance. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64416/new/ https://reviews.llvm.org/D64416 ___ cfe-commits

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

chill updated this revision to Diff 211140. This revision is now accepted and ready to land. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64416/new/ https://reviews.llvm.org/D64416 Files: clang/include/clang/Basic/BuiltinsAArch64.def clang/lib/Basic/Targets/AArch64.cpp

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

RKSimon added inline comments. Comment at: llvm/test/CodeGen/AArch64/tme-tcancel.ll:1 +; RUN: llc %s -o - | FileCheck %s + Would it make sense to add -verify-machineinstrs to all these Codegen/AArch64/tme-*.ll tests? CHANGES SINCE LAST ACTION

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

t.p.northover added inline comments. Comment at: clang/test/Sema/aarch64-tme-errors.c:1 +// RUN: %clang_cc1 -triple aarch64-eabi -verify %s + I don't think the Sema checks need to be split over so many files. One for the whole of transactional seems enough.

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64416/new/ https://reviews.llvm.org/D64416 ___ cfe-commits mailing list

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

chill updated this revision to Diff 210768. chill added a comment. This revision is now accepted and ready to land. Changed `tcancel` implementation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64416/new/ https://reviews.llvm.org/D64416 Files:

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

chill reopened this revision. chill added a comment. This revision is now accepted and ready to land. I reverted the patch, have to rework `tcancel`. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64416/new/ https://reviews.llvm.org/D64416

Re: [PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

@lists.llvm.org; jav...@graphcore.ai; Kristof Beyls; hiradi...@msn.com; llvm-comm...@lists.llvm.org; kanh...@a-bix.com; mcros...@codeaurora.org; ju...@samsung.com; diana.pi...@linaro.org; florian_h...@apple.com Subject: [PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME) RKSimon

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

RKSimon added a comment. @chill This is failing on buildbots with EXPENSIVE_CHECKS enabled: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/18684/steps/test-check-all/logs/stdio Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

This revision was automatically updated to reflect the committed changes. Closed by commit rL366322: [AArch64] Add support for Transactional Memory Extension (TME) (authored by chill, committed by ). Herald added a subscriber: kristina. Changed prior to commit: