[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-11 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL365863: NFC: Unforget a colon in a few CHECK: directives. (authored by dergachev, committed by ). Herald added a

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-11 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Thanks all! I guess i'll commit. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64526/new/ https://reviews.llvm.org/D64526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-10 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. I didn't know spaces are not allowed between "CHECK" and ":". CodeGen tests LGTM. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64526/new/ https://reviews.llvm.org/D64526 ___ cfe-commits

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-10 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere added a comment. The dsymutil part LGTM Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64526/new/ https://reviews.llvm.org/D64526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-10 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Yeah, and i removed the one in `addrspace-operators.cl` because it has already been fixed in rC365666 . Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64526/new/ https://reviews.llvm.org/D64526

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-10 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 209060. NoQ added reviewers: davidxl, aprantl, JDevlieghere. NoQ set the repository for this revision to rL LLVM. NoQ added a project: LLVM. NoQ added a comment. Herald added a subscriber: llvm-commits. Add three more fixes - two with `CHECK-NEXT` and one with

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-10 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D64526#1579174 , @thakis wrote: > (previously: D58061 ) Aha, that explains why most of these are new :) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64526/new/

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-10 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. (previously: D58061 ) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64526/new/ https://reviews.llvm.org/D64526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-10 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 209046. NoQ added a reviewer: Anastasia. NoQ added a comment. Found one more forgotten colon by grepping for `//CHECK ` instead of `// CHECK `. Removed the FIXME for @ABataev so that not to cause merge conflicts when he fixes the test. P.S. I didn't grep for

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-10 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/test/OpenMP/sections_lastprivate_codegen.cpp:31 + +// FIXME: This line doesn't work. // CHECK [[CAP_MAIN_TY:%.+]] = type { i{{[0-9]+}}*, [2 x i{{[0-9]+}}]*, [2 x [[S_FLOAT_TY]]]*,

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-10 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/test/OpenMP/sections_lastprivate_codegen.cpp:31 + +// FIXME: This line doesn't work. // CHECK [[CAP_MAIN_TY:%.+]] = type { i{{[0-9]+}}*, [2 x i{{[0-9]+}}]*, [2 x [[S_FLOAT_TY]]]*, [[S_FLOAT_TY]]*, i{{[0-9]+}}* }

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-10 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: kkwli0, ABataev, ahatanak, erik.pilkington. Herald added subscribers: cfe-commits, Charusso, jdoerfert, dexonsmith. Herald added a project: clang. I noticed that people occasionally forget that unlike `CHECK:`, directives `CHECK` and `CHECK :` are