[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-11 Thread Phabricator via Phabricator via cfe-commits 
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL365863: NFC: Unforget a colon in a few CHECK: directives. 
(authored by dergachev, committed by ).
Herald added a subscriber: delcypher.

Changed prior to commit:
  https://reviews.llvm.org/D64526?vs=209060=209402#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64526/new/

https://reviews.llvm.org/D64526

Files:
  cfe/trunk/test/Analysis/cfg-rich-constructors.cpp
  cfe/trunk/test/CodeGenCXX/noescape.cpp
  cfe/trunk/test/CodeGenObjC/externally-retained.m
  compiler-rt/trunk/test/profile/instrprof-merge.c
  llvm/trunk/test/tools/dsymutil/X86/modules.m
  llvm/trunk/test/tools/dsymutil/X86/odr-fwd-declaration.cpp


Index: cfe/trunk/test/CodeGenCXX/noescape.cpp
===
--- cfe/trunk/test/CodeGenCXX/noescape.cpp
+++ cfe/trunk/test/CodeGenCXX/noescape.cpp
@@ -45,7 +45,7 @@
 }
 
 // CHECK-LABEL: define i8* @_Z5test1Pv(
-// CHECK : %call = call {{.*}} @_ZnwmPv({{.*}}, {{.*}} nocapture {{.*}})
+// CHECK: %call = call {{.*}} @_ZnwmPv({{.*}}, {{.*}} nocapture {{.*}})
 void *test1(void *p0) {
   return ::operator new(16, p0);
 }
Index: cfe/trunk/test/Analysis/cfg-rich-constructors.cpp
===
--- cfe/trunk/test/Analysis/cfg-rich-constructors.cpp
+++ cfe/trunk/test/Analysis/cfg-rich-constructors.cpp
@@ -459,7 +459,7 @@
 // TODO: Should provide construction context for the constructor,
 // even if there is no specific trigger statement here.
 // CHECK: void simpleTemporary()
-// CHECK   1: C() (CXXConstructExpr, class C)
+// CHECK:  1: C() (CXXConstructExpr, class C)
 void simpleTemporary() {
   C();
 }
Index: cfe/trunk/test/CodeGenObjC/externally-retained.m
===
--- cfe/trunk/test/CodeGenObjC/externally-retained.m
+++ cfe/trunk/test/CodeGenObjC/externally-retained.m
@@ -22,7 +22,7 @@
 void param(ObjTy *p) EXT_RET {
   // CHECK-LABEL: define void @param
   // CHECK-NOT: llvm.objc.
-  // CHECK ret
+  // CHECK: ret
 }
 
 void local() {
Index: llvm/trunk/test/tools/dsymutil/X86/odr-fwd-declaration.cpp
===
--- llvm/trunk/test/tools/dsymutil/X86/odr-fwd-declaration.cpp
+++ llvm/trunk/test/tools/dsymutil/X86/odr-fwd-declaration.cpp
@@ -49,7 +49,7 @@
 // CHECK: AT_name{{.*}} "S"
 // CHECK-NOT: {{DW_TAG|NULL}}
 // CHECK: AT_declaration
-// CHECK-NOT AT_byte_size
+// CHECK-NOT: AT_byte_size
 
 #elif defined(FILE2)
 # 1 "Header.h" 1
Index: llvm/trunk/test/tools/dsymutil/X86/modules.m
===
--- llvm/trunk/test/tools/dsymutil/X86/modules.m
+++ llvm/trunk/test/tools/dsymutil/X86/modules.m
@@ -116,6 +116,7 @@
 // CHECK:   DW_AT_type {{.*}}{0x{{0*}}[[PTR:.*]]}
 //
 // CHECK: 0x{{0*}}[[PTR]]: DW_TAG_pointer_type
+// FIXME: The next line doesn't work.
 // CHECK-NEXT   DW_AT_type [DW_FORM_ref_addr] {0x{{0*}}[[INTERFACE]]
 extern int odr_violation;
 
Index: compiler-rt/trunk/test/profile/instrprof-merge.c
===
--- compiler-rt/trunk/test/profile/instrprof-merge.c
+++ compiler-rt/trunk/test/profile/instrprof-merge.c
@@ -90,8 +90,8 @@
 // Not profiled
 // CHECK-LABEL:  bar:
 // CHECK: Counters: 1
-// CHECK-NEXT Function count: 0
-// CHECK-NEXT Block counts: []
+// CHECK-NEXT:Function count: 0
+// CHECK-NEXT:Block counts: []
 
 // Not profiled
 // CHECK-LABEL:  main:


Index: cfe/trunk/test/CodeGenCXX/noescape.cpp
===
--- cfe/trunk/test/CodeGenCXX/noescape.cpp
+++ cfe/trunk/test/CodeGenCXX/noescape.cpp
@@ -45,7 +45,7 @@
 }
 
 // CHECK-LABEL: define i8* @_Z5test1Pv(
-// CHECK : %call = call {{.*}} @_ZnwmPv({{.*}}, {{.*}} nocapture {{.*}})
+// CHECK: %call = call {{.*}} @_ZnwmPv({{.*}}, {{.*}} nocapture {{.*}})
 void *test1(void *p0) {
   return ::operator new(16, p0);
 }
Index: cfe/trunk/test/Analysis/cfg-rich-constructors.cpp
===
--- cfe/trunk/test/Analysis/cfg-rich-constructors.cpp
+++ cfe/trunk/test/Analysis/cfg-rich-constructors.cpp
@@ -459,7 +459,7 @@
 // TODO: Should provide construction context for the constructor,
 // even if there is no specific trigger statement here.
 // CHECK: void simpleTemporary()
-// CHECK   1: C() (CXXConstructExpr, class C)
+// CHECK:  1: C() (CXXConstructExpr, class C)
 void simpleTemporary() {
   C();
 }
Index: cfe/trunk/test/CodeGenObjC/externally-retained.m
===
--- cfe/trunk/test/CodeGenObjC/externally-retained.m
+++ cfe/trunk/test/CodeGenObjC/externally-retained.m
@@ -22,7 +22,7 @@
 void

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-11 Thread Artem Dergachev via Phabricator via cfe-commits 
NoQ added a comment.

Thanks all! I guess i'll commit.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64526/new/

https://reviews.llvm.org/D64526



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-10 Thread Akira Hatanaka via Phabricator via cfe-commits 
ahatanak added a comment.

I didn't know spaces are not allowed between "CHECK" and ":". CodeGen tests 
LGTM.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64526/new/

https://reviews.llvm.org/D64526



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-10 Thread Jonas Devlieghere via Phabricator via cfe-commits 
JDevlieghere added a comment.

The dsymutil part LGTM


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64526/new/

https://reviews.llvm.org/D64526



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-10 Thread Artem Dergachev via Phabricator via cfe-commits 
NoQ added a comment.

Yeah, and i removed the one in `addrspace-operators.cl` because it has already 
been fixed in rC365666 .


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64526/new/

https://reviews.llvm.org/D64526



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-10 Thread Artem Dergachev via Phabricator via cfe-commits 
NoQ updated this revision to Diff 209060.
NoQ added reviewers: davidxl, aprantl, JDevlieghere.
NoQ set the repository for this revision to rL LLVM.
NoQ added a project: LLVM.
NoQ added a comment.
Herald added a subscriber: llvm-commits.

Add three more fixes - two with `CHECK-NEXT` and one with `CHECK-NOT`, in LLVM 
and compiler-rt.

One of the LLVM changes doesn't pass after the fix, so i added a FIXME instead.

I didn't immediately figure out how to compile compiler-rt so i didn't really 
have a look if the test passes; could use some help or i guess the buildbots 
will eventually tell me :)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64526/new/

https://reviews.llvm.org/D64526

Files:
  clang/test/Analysis/cfg-rich-constructors.cpp
  clang/test/CodeGenCXX/noescape.cpp
  clang/test/CodeGenObjC/externally-retained.m
  compiler-rt/test/profile/instrprof-merge.c
  llvm/test/tools/dsymutil/X86/modules.m
  llvm/test/tools/dsymutil/X86/odr-fwd-declaration.cpp


Index: llvm/test/tools/dsymutil/X86/odr-fwd-declaration.cpp
===
--- llvm/test/tools/dsymutil/X86/odr-fwd-declaration.cpp
+++ llvm/test/tools/dsymutil/X86/odr-fwd-declaration.cpp
@@ -49,7 +49,7 @@
 // CHECK: AT_name{{.*}} "S"
 // CHECK-NOT: {{DW_TAG|NULL}}
 // CHECK: AT_declaration
-// CHECK-NOT AT_byte_size
+// CHECK-NOT: AT_byte_size
 
 #elif defined(FILE2)
 # 1 "Header.h" 1
Index: llvm/test/tools/dsymutil/X86/modules.m
===
--- llvm/test/tools/dsymutil/X86/modules.m
+++ llvm/test/tools/dsymutil/X86/modules.m
@@ -116,6 +116,7 @@
 // CHECK:   DW_AT_type {{.*}}{0x{{0*}}[[PTR:.*]]}
 //
 // CHECK: 0x{{0*}}[[PTR]]: DW_TAG_pointer_type
+// FIXME: The next line doesn't work.
 // CHECK-NEXT   DW_AT_type [DW_FORM_ref_addr] {0x{{0*}}[[INTERFACE]]
 extern int odr_violation;
 
Index: compiler-rt/test/profile/instrprof-merge.c
===
--- compiler-rt/test/profile/instrprof-merge.c
+++ compiler-rt/test/profile/instrprof-merge.c
@@ -89,8 +89,8 @@
 // Not profiled
 // CHECK-LABEL:  bar:
 // CHECK: Counters: 1
-// CHECK-NEXT Function count: 0
-// CHECK-NEXT Block counts: []
+// CHECK-NEXT:Function count: 0
+// CHECK-NEXT:Block counts: []
 
 // Not profiled
 // CHECK-LABEL:  main:
Index: clang/test/CodeGenObjC/externally-retained.m
===
--- clang/test/CodeGenObjC/externally-retained.m
+++ clang/test/CodeGenObjC/externally-retained.m
@@ -22,7 +22,7 @@
 void param(ObjTy *p) EXT_RET {
   // CHECK-LABEL: define void @param
   // CHECK-NOT: llvm.objc.
-  // CHECK ret
+  // CHECK: ret
 }
 
 void local() {
Index: clang/test/CodeGenCXX/noescape.cpp
===
--- clang/test/CodeGenCXX/noescape.cpp
+++ clang/test/CodeGenCXX/noescape.cpp
@@ -45,7 +45,7 @@
 }
 
 // CHECK-LABEL: define i8* @_Z5test1Pv(
-// CHECK : %call = call {{.*}} @_ZnwmPv({{.*}}, {{.*}} nocapture {{.*}})
+// CHECK: %call = call {{.*}} @_ZnwmPv({{.*}}, {{.*}} nocapture {{.*}})
 void *test1(void *p0) {
   return ::operator new(16, p0);
 }
Index: clang/test/Analysis/cfg-rich-constructors.cpp
===
--- clang/test/Analysis/cfg-rich-constructors.cpp
+++ clang/test/Analysis/cfg-rich-constructors.cpp
@@ -459,7 +459,7 @@
 // TODO: Should provide construction context for the constructor,
 // even if there is no specific trigger statement here.
 // CHECK: void simpleTemporary()
-// CHECK   1: C() (CXXConstructExpr, class C)
+// CHECK:  1: C() (CXXConstructExpr, class C)
 void simpleTemporary() {
   C();
 }


Index: llvm/test/tools/dsymutil/X86/odr-fwd-declaration.cpp
===
--- llvm/test/tools/dsymutil/X86/odr-fwd-declaration.cpp
+++ llvm/test/tools/dsymutil/X86/odr-fwd-declaration.cpp
@@ -49,7 +49,7 @@
 // CHECK: AT_name{{.*}} "S"
 // CHECK-NOT: {{DW_TAG|NULL}}
 // CHECK: AT_declaration
-// CHECK-NOT AT_byte_size
+// CHECK-NOT: AT_byte_size
 
 #elif defined(FILE2)
 # 1 "Header.h" 1
Index: llvm/test/tools/dsymutil/X86/modules.m
===
--- llvm/test/tools/dsymutil/X86/modules.m
+++ llvm/test/tools/dsymutil/X86/modules.m
@@ -116,6 +116,7 @@
 // CHECK:   DW_AT_type {{.*}}{0x{{0*}}[[PTR:.*]]}
 //
 // CHECK: 0x{{0*}}[[PTR]]: DW_TAG_pointer_type
+// FIXME: The next line doesn't work.
 // CHECK-NEXT   DW_AT_type [DW_FORM_ref_addr] {0x{{0*}}[[INTERFACE]]
 extern int odr_violation;
 
Index: compiler-rt/test/profile/instrprof-merge.c
===
--- compiler-rt/test/profile/instrprof-merge.c
+++ compiler-rt/test/profile/instrprof-merge.c
@@ -89,8 +89,8 @@
 // Not profiled
 // CHECK-LABEL:  bar:
 // CHECK:

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-10 Thread Artem Dergachev via Phabricator via cfe-commits 
NoQ added a comment.

In D64526#1579174 , @thakis wrote:

> (previously: D58061 )


Aha, that explains why most of these are new :)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64526/new/

https://reviews.llvm.org/D64526



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-10 Thread Nico Weber via Phabricator via cfe-commits 
thakis added a comment.

(previously: D58061 )


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64526/new/

https://reviews.llvm.org/D64526



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-10 Thread Artem Dergachev via Phabricator via cfe-commits 
NoQ updated this revision to Diff 209046.
NoQ added a reviewer: Anastasia.
NoQ added a comment.

Found one more forgotten colon by grepping for `//CHECK ` instead of `// CHECK 
`.

Removed the FIXME for @ABataev so that not to cause merge conflicts when he 
fixes the test.

P.S. I didn't grep for custom FileCheck prefixes. Those may have more bugs.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64526/new/

https://reviews.llvm.org/D64526

Files:
  clang/test/Analysis/cfg-rich-constructors.cpp
  clang/test/CodeGenCXX/noescape.cpp
  clang/test/CodeGenObjC/externally-retained.m
  clang/test/CodeGenOpenCLCXX/addrspace-operators.cl


Index: clang/test/CodeGenOpenCLCXX/addrspace-operators.cl
===
--- clang/test/CodeGenOpenCLCXX/addrspace-operators.cl
+++ clang/test/CodeGenOpenCLCXX/addrspace-operators.cl
@@ -46,7 +46,7 @@
 //CHECK: %me = getelementptr inbounds %class.C, %class.C addrspace(4)* %this1, 
i32 0, i32 0
 //CHECK: store i32 [[E]], i32 addrspace(4)* %me
 
-//CHECK define linkonce_odr void @_ZNU3AS41C8OrAssignE1E(%class.C 
addrspace(4)* %this, i32 %e)
+//CHECK: define linkonce_odr void @_ZNU3AS41C8OrAssignE1E(%class.C 
addrspace(4)* %this, i32 %e)
 //CHECK: [[E:%[0-9]+]] = load i32, i32* %e.addr
 //CHECK: %mi = getelementptr inbounds %class.C, %class.C addrspace(4)* %this1, 
i32 0, i32 1
 //CHECK: [[MI:%[0-9]+]] = load i32, i32 addrspace(4)* %mi
Index: clang/test/CodeGenObjC/externally-retained.m
===
--- clang/test/CodeGenObjC/externally-retained.m
+++ clang/test/CodeGenObjC/externally-retained.m
@@ -22,7 +22,7 @@
 void param(ObjTy *p) EXT_RET {
   // CHECK-LABEL: define void @param
   // CHECK-NOT: llvm.objc.
-  // CHECK ret
+  // CHECK: ret
 }
 
 void local() {
Index: clang/test/CodeGenCXX/noescape.cpp
===
--- clang/test/CodeGenCXX/noescape.cpp
+++ clang/test/CodeGenCXX/noescape.cpp
@@ -45,7 +45,7 @@
 }
 
 // CHECK-LABEL: define i8* @_Z5test1Pv(
-// CHECK : %call = call {{.*}} @_ZnwmPv({{.*}}, {{.*}} nocapture {{.*}})
+// CHECK: %call = call {{.*}} @_ZnwmPv({{.*}}, {{.*}} nocapture {{.*}})
 void *test1(void *p0) {
   return ::operator new(16, p0);
 }
Index: clang/test/Analysis/cfg-rich-constructors.cpp
===
--- clang/test/Analysis/cfg-rich-constructors.cpp
+++ clang/test/Analysis/cfg-rich-constructors.cpp
@@ -459,7 +459,7 @@
 // TODO: Should provide construction context for the constructor,
 // even if there is no specific trigger statement here.
 // CHECK: void simpleTemporary()
-// CHECK   1: C() (CXXConstructExpr, class C)
+// CHECK:  1: C() (CXXConstructExpr, class C)
 void simpleTemporary() {
   C();
 }


Index: clang/test/CodeGenOpenCLCXX/addrspace-operators.cl
===
--- clang/test/CodeGenOpenCLCXX/addrspace-operators.cl
+++ clang/test/CodeGenOpenCLCXX/addrspace-operators.cl
@@ -46,7 +46,7 @@
 //CHECK: %me = getelementptr inbounds %class.C, %class.C addrspace(4)* %this1, i32 0, i32 0
 //CHECK: store i32 [[E]], i32 addrspace(4)* %me
 
-//CHECK define linkonce_odr void @_ZNU3AS41C8OrAssignE1E(%class.C addrspace(4)* %this, i32 %e)
+//CHECK: define linkonce_odr void @_ZNU3AS41C8OrAssignE1E(%class.C addrspace(4)* %this, i32 %e)
 //CHECK: [[E:%[0-9]+]] = load i32, i32* %e.addr
 //CHECK: %mi = getelementptr inbounds %class.C, %class.C addrspace(4)* %this1, i32 0, i32 1
 //CHECK: [[MI:%[0-9]+]] = load i32, i32 addrspace(4)* %mi
Index: clang/test/CodeGenObjC/externally-retained.m
===
--- clang/test/CodeGenObjC/externally-retained.m
+++ clang/test/CodeGenObjC/externally-retained.m
@@ -22,7 +22,7 @@
 void param(ObjTy *p) EXT_RET {
   // CHECK-LABEL: define void @param
   // CHECK-NOT: llvm.objc.
-  // CHECK ret
+  // CHECK: ret
 }
 
 void local() {
Index: clang/test/CodeGenCXX/noescape.cpp
===
--- clang/test/CodeGenCXX/noescape.cpp
+++ clang/test/CodeGenCXX/noescape.cpp
@@ -45,7 +45,7 @@
 }
 
 // CHECK-LABEL: define i8* @_Z5test1Pv(
-// CHECK : %call = call {{.*}} @_ZnwmPv({{.*}}, {{.*}} nocapture {{.*}})
+// CHECK: %call = call {{.*}} @_ZnwmPv({{.*}}, {{.*}} nocapture {{.*}})
 void *test1(void *p0) {
   return ::operator new(16, p0);
 }
Index: clang/test/Analysis/cfg-rich-constructors.cpp
===
--- clang/test/Analysis/cfg-rich-constructors.cpp
+++ clang/test/Analysis/cfg-rich-constructors.cpp
@@ -459,7 +459,7 @@
 // TODO: Should provide construction context for the constructor,
 // even if there is no specific trigger statement here.
 // CHECK: void simpleTemporary()
-// CHECK   1: C() (CXXConstructExpr, class C)
+// CHECK:  1: C() (CXXConstructExpr, class C)
 void

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-10 Thread Artem Dergachev via Phabricator via cfe-commits 
NoQ marked an inline comment as done.
NoQ added inline comments.



Comment at: clang/test/OpenMP/sections_lastprivate_codegen.cpp:31
+
+// FIXME: This line doesn't work.
 // CHECK [[CAP_MAIN_TY:%.+]] = type { i{{[0-9]+}}*, [2 x i{{[0-9]+}}]*, [2 x 
[[S_FLOAT_TY]]]*, [[S_FLOAT_TY]]*, i{{[0-9]+}}* }

ABataev wrote:
> I'll fix this test.
Yay!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64526/new/

https://reviews.llvm.org/D64526



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-10 Thread Alexey Bataev via Phabricator via cfe-commits 
ABataev added inline comments.



Comment at: clang/test/OpenMP/sections_lastprivate_codegen.cpp:31
+
+// FIXME: This line doesn't work.
 // CHECK [[CAP_MAIN_TY:%.+]] = type { i{{[0-9]+}}*, [2 x i{{[0-9]+}}]*, [2 x 
[[S_FLOAT_TY]]]*, [[S_FLOAT_TY]]*, i{{[0-9]+}}* }

I'll fix this test.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64526/new/

https://reviews.llvm.org/D64526



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-10 Thread Artem Dergachev via Phabricator via cfe-commits 
NoQ created this revision.
NoQ added reviewers: kkwli0, ABataev, ahatanak, erik.pilkington.
Herald added subscribers: cfe-commits, Charusso, jdoerfert, dexonsmith.
Herald added a project: clang.

I noticed that people occasionally forget that unlike `CHECK:`, directives 
`CHECK` and `CHECK :` are not reacted upon by FileCheck. Tests still pass, but 
they don't actually test anything.

So i grepped real quick and found these four missing colons, one of which (the 
one in `Analysis/cfg-rich-constructors.cpp`) is mine. All four are in clang; 
there aren't any missing colons in other projects in the monorepo.

I'm not entirely sure about the change 
`OpenMP/sections_lastprivate_codegen.cpp`: it seems that replacing `CHECK:` 
with `CHECK` is a common way of making FIXME tests, but there's no indication 
anywhere that this is a known issue. The test was added in D11619 
.


Repository:
  rC Clang

https://reviews.llvm.org/D64526

Files:
  clang/test/Analysis/cfg-rich-constructors.cpp
  clang/test/CodeGenCXX/noescape.cpp
  clang/test/CodeGenObjC/externally-retained.m
  clang/test/OpenMP/sections_lastprivate_codegen.cpp


Index: clang/test/OpenMP/sections_lastprivate_codegen.cpp
===
--- clang/test/OpenMP/sections_lastprivate_codegen.cpp
+++ clang/test/OpenMP/sections_lastprivate_codegen.cpp
@@ -27,7 +27,10 @@
 volatile int g = 1212;
 
 // CHECK: [[S_FLOAT_TY:%.+]] = type { float }
+
+// FIXME: This line doesn't work.
 // CHECK [[CAP_MAIN_TY:%.+]] = type { i{{[0-9]+}}*, [2 x i{{[0-9]+}}]*, [2 x 
[[S_FLOAT_TY]]]*, [[S_FLOAT_TY]]*, i{{[0-9]+}}* }
+
 // CHECK: [[S_INT_TY:%.+]] = type { i32 }
 // CHECK-DAG: [[SECTIONS_BARRIER_LOC:@.+]] = private unnamed_addr global 
%{{.+}} { i32 0, i32 194, i32 0, i32 0, i8*
 // CHECK-DAG: [[X:@.+]] = global double 0.0
Index: clang/test/CodeGenObjC/externally-retained.m
===
--- clang/test/CodeGenObjC/externally-retained.m
+++ clang/test/CodeGenObjC/externally-retained.m
@@ -22,7 +22,7 @@
 void param(ObjTy *p) EXT_RET {
   // CHECK-LABEL: define void @param
   // CHECK-NOT: llvm.objc.
-  // CHECK ret
+  // CHECK: ret
 }
 
 void local() {
Index: clang/test/CodeGenCXX/noescape.cpp
===
--- clang/test/CodeGenCXX/noescape.cpp
+++ clang/test/CodeGenCXX/noescape.cpp
@@ -45,7 +45,7 @@
 }
 
 // CHECK-LABEL: define i8* @_Z5test1Pv(
-// CHECK : %call = call {{.*}} @_ZnwmPv({{.*}}, {{.*}} nocapture {{.*}})
+// CHECK: %call = call {{.*}} @_ZnwmPv({{.*}}, {{.*}} nocapture {{.*}})
 void *test1(void *p0) {
   return ::operator new(16, p0);
 }
Index: clang/test/Analysis/cfg-rich-constructors.cpp
===
--- clang/test/Analysis/cfg-rich-constructors.cpp
+++ clang/test/Analysis/cfg-rich-constructors.cpp
@@ -459,7 +459,7 @@
 // TODO: Should provide construction context for the constructor,
 // even if there is no specific trigger statement here.
 // CHECK: void simpleTemporary()
-// CHECK   1: C() (CXXConstructExpr, class C)
+// CHECK:  1: C() (CXXConstructExpr, class C)
 void simpleTemporary() {
   C();
 }


Index: clang/test/OpenMP/sections_lastprivate_codegen.cpp
===
--- clang/test/OpenMP/sections_lastprivate_codegen.cpp
+++ clang/test/OpenMP/sections_lastprivate_codegen.cpp
@@ -27,7 +27,10 @@
 volatile int g = 1212;
 
 // CHECK: [[S_FLOAT_TY:%.+]] = type { float }
+
+// FIXME: This line doesn't work.
 // CHECK [[CAP_MAIN_TY:%.+]] = type { i{{[0-9]+}}*, [2 x i{{[0-9]+}}]*, [2 x [[S_FLOAT_TY]]]*, [[S_FLOAT_TY]]*, i{{[0-9]+}}* }
+
 // CHECK: [[S_INT_TY:%.+]] = type { i32 }
 // CHECK-DAG: [[SECTIONS_BARRIER_LOC:@.+]] = private unnamed_addr global %{{.+}} { i32 0, i32 194, i32 0, i32 0, i8*
 // CHECK-DAG: [[X:@.+]] = global double 0.0
Index: clang/test/CodeGenObjC/externally-retained.m
===
--- clang/test/CodeGenObjC/externally-retained.m
+++ clang/test/CodeGenObjC/externally-retained.m
@@ -22,7 +22,7 @@
 void param(ObjTy *p) EXT_RET {
   // CHECK-LABEL: define void @param
   // CHECK-NOT: llvm.objc.
-  // CHECK ret
+  // CHECK: ret
 }
 
 void local() {
Index: clang/test/CodeGenCXX/noescape.cpp
===
--- clang/test/CodeGenCXX/noescape.cpp
+++ clang/test/CodeGenCXX/noescape.cpp
@@ -45,7 +45,7 @@
 }
 
 // CHECK-LABEL: define i8* @_Z5test1Pv(
-// CHECK : %call = call {{.*}} @_ZnwmPv({{.*}}, {{.*}} nocapture {{.*}})
+// CHECK: %call = call {{.*}} @_ZnwmPv({{.*}}, {{.*}} nocapture {{.*}})
 void *test1(void *p0) {
   return ::operator new(16, p0);
 }
Index: clang/test/Analysis/cfg-rich-constructors.cpp
===
--- clang/test/Analysis/cfg-rich-constructors.cpp
+++