[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

nickdesaulniers added a comment. Fixup: https://reviews.llvm.org/D64655 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64527/new/ https://reviews.llvm.org/D64527 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

Yes, the current behavior is erroring for assembler flags clang does not recognize, which is irrelevant when compiling with `-no-integrated-as`, which is breaking our assembler flag feature detection in building the Linux kernel. On Thu, Jul 11, 2019, 6:09 PM Reid Kleckner via Phabricator < revi..

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

rnk added a comment. I think the intention of this change was to ignore assembler flags in pre-processing actions without warning about them. It implements that behavior by running the code that gathers and validates assembler flags. The validation is whats emitting the problematic errors. I do

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

nickdesaulniers added inline comments. Comment at: cfe/trunk/lib/Driver/ToolChains/Clang.cpp:3555 + // in -E mode either for example, even though it's not really used either. + if (!isa(JA)) { +ArgStringList DummyArgs; Should you be checking `!TC.IsIntegrat

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

nickdesaulniers added a comment. ah, maybe the addition of `-no-integrated-as` shouldn't produce this error? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64527/new/ https://reviews.llvm.org/D64527 ___ cfe-commits mai

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

nickdesaulniers added a comment. > This change breaks building the Linux kernel for arm32 (at least): Follow up discussion in https://github.com/ClangBuiltLinux/linux/issues/598. I think the kernel is wrong here. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D645

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

nathanchance added a comment. This change breaks building the Linux kernel for arm32 (at least): ... YACCscripts/dtc/dtc-parser.tab.c HOSTCC scripts/dtc/yamltree.o HOSTCC scripts/dtc/dtc-parser.tab.o HOSTCC scripts/dtc/dtc-lexer.lex.o HOSTLD scripts/dtc/dtc UPD

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

This revision was automatically updated to reflect the committed changes. Closed by commit rL365703: driver: Don't warn about assembler flags being unused when not assembling (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64527/new/ https://reviews.llvm.org/D64527 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

thakis created this revision. thakis added a reviewer: rnk. Herald added subscribers: kristof.beyls, javed.absar. clang currently warns when passing flags for the assembler (e.g. -Wa,-mbig-obj) to an invocation that doesn't run the assembler (e.g. -E). At first sight, that makes sense -- the flag