[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb5d8e3db253: [clang-doc] Add stylesheet to generated html docs (authored by DiegoAstiazaran). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

DiegoAstiazaran updated this revision to Diff 211820. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64539/new/ https://reviews.llvm.org/D64539 Files: clang-tools-extra/clang-doc/Generators.h clang-tools-extra/clang-doc/HTMLGenerator.cpp clang-tools-extra/clang-doc/MDGenerator.cpp

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

juliehockett accepted this revision. juliehockett added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64539/new/ https://reviews.llvm.org/D64539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

DiegoAstiazaran updated this revision to Diff 210688. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64539/new/ https://reviews.llvm.org/D64539 Files: clang-tools-extra/clang-doc/Generators.h clang-tools-extra/clang-doc/HTMLGenerator.cpp clang-tools-extra/clang-doc/MDGenerator.cpp

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

juliehockett accepted this revision. juliehockett added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64539/new/ https://reviews.llvm.org/D64539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

jakehehrlich added a comment. I'm blindly accepting the CSS but all other code looks fine. I still have that chrome bug where I can't LGTM sometimes but consider this reviewed and accepted by me as well CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64539/new/

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

DiegoAstiazaran updated this revision to Diff 210394. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Herald added a subscriber: mgorny. Move the CSS file to share/clang and read it from there, instead of trying to read it from the file that's with the

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

DiegoAstiazaran updated this revision to Diff 209302. DiegoAstiazaran marked an inline comment as done. DiegoAstiazaran added a comment. Move the generation of css stylesheet to a function inside the HTMLGenerator. A virtual function createResources was declared for Generator class. This is

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:242 + // Generate css stylesheet + if (Format == "html") { On second thought, can you create a virtual method to the Generator along the lines of

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

DiegoAstiazaran updated this revision to Diff 209088. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Use `llvm::sys::fs::copy_file` to copy css file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64539/new/ https://reviews.llvm.org/D64539 Files:

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:247 +auto StylesheetPathWrite = getInfoOutputFile( +OutDirectory, "", "clang-doc-default-stylesheet", ".css"); +if (!StylesheetPathWrite) {

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:246-271 +auto StylesheetPathWrite = getInfoOutputFile( +OutDirectory, "", "clang-doc-default-stylesheet", ".css"); +if (!StylesheetPathWrite) { + llvm::errs()

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. A default css stylesheet is included for docs generated in html format. Depends on