[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

2019-07-12 Thread Vitaly Buka via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365921: CodeGet: Init 32bit pointers with 0x (authored by vitalybuka, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

2019-07-12 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a comment. In D64597#1582950 , @jfb wrote: > On 32-bit platforms the only region that's likely to trap is the zero page. > This seems to be the best choice, but platforms with other regions should be > able to tune this value

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

2019-07-12 Thread JF Bastien via Phabricator via cfe-commits
jfb added a comment. In D64597#1582944 , @hubert.reinterpretcast wrote: > In D64597#1581605 , @pcc wrote: > > > The problem with `0x` on 32-bit is that it is likely to be a valid > > address. > > > > When

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

2019-07-12 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added a comment. In D64597#1582944 , @hubert.reinterpretcast wrote: > In D64597#1581605 , @pcc wrote: > > > The problem with `0x` on 32-bit is that it is likely to be a valid > > address. > > > > When

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

2019-07-12 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a comment. In D64597#1581605 , @pcc wrote: > The problem with `0x` on 32-bit is that it is likely to be a valid > address. > > When I discussed this with JF I proposed a pointer initialization of > `0x` which

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

2019-07-11 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka updated this revision to Diff 209401. vitalybuka added a comment. undo unrelated line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64597/new/ https://reviews.llvm.org/D64597 Files: clang/lib/CodeGen/PatternInit.cpp clang/test/CodeG

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

2019-07-11 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka updated this revision to Diff 209400. vitalybuka added a comment. 0x Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64597/new/ https://reviews.llvm.org/D64597 Files: clang/lib/CodeGen/PatternInit.cpp clang/test/CodeGenCXX/aut

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

2019-07-11 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a comment. In D64597#1581654 , @jfb wrote: > In D64597#1581605 , @pcc wrote: > > > The problem with `0x` on 32-bit is that it is likely to be a valid > > address. > > > > When I discussed t