[PATCH] D64600: [ObjC] Add an attribute that "clamps" signed char BOOLs to {0,1}

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3279 +def ObjCClampingBool : TypeAttr { + let Spellings = [Clang<"objc_clamping_bool">]; + let Subjects = SubjectList<[TypedefName]>; dexonsmith wrote: > erik.pilkington wrote:

[PATCH] D64600: [ObjC] Add an attribute that "clamps" signed char BOOLs to {0,1}

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3279 +def ObjCClampingBool : TypeAttr { + let Spellings = [Clang<"objc_clamping_bool">]; + let Subjects = SubjectList<[TypedefName]>; erik.pilkington wrote: > aaron.ballman wrote:

[PATCH] D64600: [ObjC] Add an attribute that "clamps" signed char BOOLs to {0,1}

erik.pilkington added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3279 +def ObjCClampingBool : TypeAttr { + let Spellings = [Clang<"objc_clamping_bool">]; + let Subjects = SubjectList<[TypedefName]>; aaron.ballman wrote: > Is there a desire

[PATCH] D64600: [ObjC] Add an attribute that "clamps" signed char BOOLs to {0,1}

erik.pilkington updated this revision to Diff 209603. erik.pilkington marked 2 inline comments as done. erik.pilkington added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64600/new/ https://reviews.llvm.org/D64600 Files:

[PATCH] D64600: [ObjC] Add an attribute that "clamps" signed char BOOLs to {0,1}

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3279 +def ObjCClampingBool : TypeAttr { + let Spellings = [Clang<"objc_clamping_bool">]; + let Subjects = SubjectList<[TypedefName]>; Is there a desire for similar functionality

[PATCH] D64600: [ObjC] Add an attribute that "clamps" signed char BOOLs to {0,1}

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, aaron.ballman, steven_wu. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. This attribute can be applied to typedefs of BOOL in Objective-C. It causes loads, stores, and casts to BOOL