[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

This revision was automatically updated to reflect the committed changes. Closed by commit rL366338: [clangd] Type hierarchy: dont resolve parents if the client only asked for… (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64613/new/ https://reviews.llvm.org/D64613

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

nridge marked an inline comment as done. nridge added a comment. (Changed reviewer to Kadir as he reviewed the previous version.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64613/new/ https://reviews.llvm.org/D64613

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

nridge marked 2 inline comments as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1238 Optional Result = - getTypeAncestors(*CXXRD, AST.getASTContext(), RPSet); + getTypeAncestors(*CXXRD, AST.getASTContext(), RPSet,

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

nridge updated this revision to Diff 209677. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64613/new/ https://reviews.llvm.org/D64613 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1238 Optional Result = - getTypeAncestors(*CXXRD, AST.getASTContext(), RPSet); + getTypeAncestors(*CXXRD, AST.getASTContext(), RPSet, ResolveParents); if (!Result)

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

nridge added a comment. This is an issue I noticed while writing the unit test for D64308 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64613/new/ https://reviews.llvm.org/D64613

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64613 Files: