sammccall added a comment.
Refactoring generally looks good.
You're replacing a lot of documented code with new undocumented code, can we
add some high-level comments?
Comment at: clang-tools-extra/clangd/index/Background.cpp:130
+
+bool hasChanged(llvm::vfs::FileSystem *FS,
kadircet updated this revision to Diff 210303.
kadircet added a comment.
- As discussed offline, moved the "staleness" detection back to background index
- A renaming within Rebuilder, "LoadedTUs -> LoadedShards"
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
sammccall added a comment.
So I've stared at this refactoring for a while, and I still don't totally get
it.
It seems like a class that really wants to be a function. It's a complicated
function though - maybe a separate cpp file does make sense.
We discussed moving ShardVersions and Writes
