[PATCH] D65146: [clangd] Log version, cwd, args, and transport on startup. NFC

2019-07-23 Thread Sam McCall via Phabricator via cfe-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rL366811: [clangd] Log version, cwd, args, and transport on 
startup. NFC (authored by sammccall, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Changed prior to commit:
  https://reviews.llvm.org/D65146?vs=211295=211301#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65146/new/

https://reviews.llvm.org/D65146

Files:
  clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp


Index: clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp
===
--- clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp
+++ clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp
@@ -423,6 +423,17 @@
   llvm::errs().SetBuffered();
   StreamLogger Logger(llvm::errs(), LogLevel);
   LoggingSession LoggingSession(Logger);
+  // Write some initial logs before we start doing any real work.
+  log("{0}", clang::getClangToolFullVersion("clangd"));
+  {
+SmallString<128> CWD;
+if (auto Err = llvm::sys::fs::current_path(CWD))
+  log("Working directory unknown: {0}", Err.message());
+else
+  log("Working directory: {0}", CWD);
+  }
+  for (int I = 0; I < argc; ++I)
+log("argv[{0}]: {1}", I, argv[I]);
 
   // If --compile-commands-dir arg was invoked, check value and override 
default
   // path.
@@ -501,12 +512,14 @@
   std::unique_ptr TransportLayer;
   if (getenv("CLANGD_AS_XPC_SERVICE")) {
 #if CLANGD_BUILD_XPC
+log("Starting LSP over XPC service");
 TransportLayer = newXPCTransport();
 #else
 llvm::errs() << "This clangd binary wasn't built with XPC support.\n";
 return (int)ErrorResultCode::CantRunAsXPCService;
 #endif
   } else {
+log("Starting LSP over stdin/stdout");
 TransportLayer = newJSONTransport(
 stdin, llvm::outs(),
 InputMirrorStream ? InputMirrorStream.getPointer() : nullptr,


Index: clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp
===
--- clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp
+++ clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp
@@ -423,6 +423,17 @@
   llvm::errs().SetBuffered();
   StreamLogger Logger(llvm::errs(), LogLevel);
   LoggingSession LoggingSession(Logger);
+  // Write some initial logs before we start doing any real work.
+  log("{0}", clang::getClangToolFullVersion("clangd"));
+  {
+SmallString<128> CWD;
+if (auto Err = llvm::sys::fs::current_path(CWD))
+  log("Working directory unknown: {0}", Err.message());
+else
+  log("Working directory: {0}", CWD);
+  }
+  for (int I = 0; I < argc; ++I)
+log("argv[{0}]: {1}", I, argv[I]);
 
   // If --compile-commands-dir arg was invoked, check value and override default
   // path.
@@ -501,12 +512,14 @@
   std::unique_ptr TransportLayer;
   if (getenv("CLANGD_AS_XPC_SERVICE")) {
 #if CLANGD_BUILD_XPC
+log("Starting LSP over XPC service");
 TransportLayer = newXPCTransport();
 #else
 llvm::errs() << "This clangd binary wasn't built with XPC support.\n";
 return (int)ErrorResultCode::CantRunAsXPCService;
 #endif
   } else {
+log("Starting LSP over stdin/stdout");
 TransportLayer = newJSONTransport(
 stdin, llvm::outs(),
 InputMirrorStream ? InputMirrorStream.getPointer() : nullptr,
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D65146: [clangd] Log version, cwd, args, and transport on startup. NFC

2019-07-23 Thread Haojian Wu via Phabricator via cfe-commits 
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.



Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:436
+  {
+std::string LoggableArgs;
+for (int I = 0; I < argc; ++I)

this variable is not used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65146/new/

https://reviews.llvm.org/D65146



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D65146: [clangd] Log version, cwd, args, and transport on startup. NFC

2019-07-23 Thread Sam McCall via Phabricator via cfe-commits 
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, 
ilya-biryukov.
Herald added a project: clang.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D65146

Files:
  clang-tools-extra/clangd/tool/ClangdMain.cpp


Index: clang-tools-extra/clangd/tool/ClangdMain.cpp
===
--- clang-tools-extra/clangd/tool/ClangdMain.cpp
+++ clang-tools-extra/clangd/tool/ClangdMain.cpp
@@ -423,6 +423,20 @@
   llvm::errs().SetBuffered();
   StreamLogger Logger(llvm::errs(), LogLevel);
   LoggingSession LoggingSession(Logger);
+  // Write some initial logs before we start doing any real work.
+  log("{0}", clang::getClangToolFullVersion("clangd"));
+  {
+SmallString<128> CWD;
+if (auto Err = llvm::sys::fs::current_path(CWD))
+  log("Working directory unknown: {0}", Err.message());
+else
+  log("Working directory: {0}", CWD);
+  }
+  {
+std::string LoggableArgs;
+for (int I = 0; I < argc; ++I)
+  log("argv[{0}]: {1}", I, argv[I]);
+  }
 
   // If --compile-commands-dir arg was invoked, check value and override 
default
   // path.
@@ -501,12 +515,14 @@
   std::unique_ptr TransportLayer;
   if (getenv("CLANGD_AS_XPC_SERVICE")) {
 #if CLANGD_BUILD_XPC
+log("Starting LSP over XPC service");
 TransportLayer = newXPCTransport();
 #else
 llvm::errs() << "This clangd binary wasn't built with XPC support.\n";
 return (int)ErrorResultCode::CantRunAsXPCService;
 #endif
   } else {
+log("Starting LSP over stdin/stdout");
 TransportLayer = newJSONTransport(
 stdin, llvm::outs(),
 InputMirrorStream ? InputMirrorStream.getPointer() : nullptr,


Index: clang-tools-extra/clangd/tool/ClangdMain.cpp
===
--- clang-tools-extra/clangd/tool/ClangdMain.cpp
+++ clang-tools-extra/clangd/tool/ClangdMain.cpp
@@ -423,6 +423,20 @@
   llvm::errs().SetBuffered();
   StreamLogger Logger(llvm::errs(), LogLevel);
   LoggingSession LoggingSession(Logger);
+  // Write some initial logs before we start doing any real work.
+  log("{0}", clang::getClangToolFullVersion("clangd"));
+  {
+SmallString<128> CWD;
+if (auto Err = llvm::sys::fs::current_path(CWD))
+  log("Working directory unknown: {0}", Err.message());
+else
+  log("Working directory: {0}", CWD);
+  }
+  {
+std::string LoggableArgs;
+for (int I = 0; I < argc; ++I)
+  log("argv[{0}]: {1}", I, argv[I]);
+  }
 
   // If --compile-commands-dir arg was invoked, check value and override default
   // path.
@@ -501,12 +515,14 @@
   std::unique_ptr TransportLayer;
   if (getenv("CLANGD_AS_XPC_SERVICE")) {
 #if CLANGD_BUILD_XPC
+log("Starting LSP over XPC service");
 TransportLayer = newXPCTransport();
 #else
 llvm::errs() << "This clangd binary wasn't built with XPC support.\n";
 return (int)ErrorResultCode::CantRunAsXPCService;
 #endif
   } else {
+log("Starting LSP over stdin/stdout");
 TransportLayer = newJSONTransport(
 stdin, llvm::outs(),
 InputMirrorStream ? InputMirrorStream.getPointer() : nullptr,
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits