[PATCH] D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

This revision was automatically updated to reflect the committed changes. Closed by commit rL367063: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2. (authored by zer0, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

plotfi marked 4 inline comments as done. plotfi added inline comments. Comment at: clang/include/clang/Driver/Types.def:39-45 +// Some of the options in Flags have been removed, so far those are: +// a - The type should only be assembled: Now, check that Phases contains +//

[PATCH] D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

plotfi updated this revision to Diff 211652. plotfi added a comment. Removing 'A' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65176/new/ https://reviews.llvm.org/D65176 Files: clang/include/clang/Driver/Types.def clang/lib/Driver/Types.cpp

[PATCH] D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/include/clang/Driver/Types.def:39-45 +// Some of the options in Flags have been removed, so far those are: +// a - The type should

[PATCH] D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

compnerd added inline comments. Comment at: clang/include/clang/Driver/Types.def:39-45 +// Some of the options in Flags have been removed, so far those are: +// a - The type should only be assembled: Now, check that Phases contains +// phases::Assemble but not

[PATCH] D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

aaron.ballman added inline comments. Comment at: clang/include/clang/Driver/Types.def:39-45 +// Some of the options in Flags have been removed, so far those are: +// a - The type should only be assembled: Now, check that Phases contains +// phases::Assemble but not

[PATCH] D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

plotfi added a comment. In D65176#1598431 , @compnerd wrote: > This looks good to me generally. I don't fully understand the reason for `u` > being kept, is that something you intend to clean up in a subsequent patch? I’d like to remove it but I don’t

[PATCH] D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

compnerd added a comment. This looks good to me generally. I don't fully understand the reason for `u` being kept, is that something you intend to clean up in a subsequent patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65176/new/

[PATCH] D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

plotfi created this revision. plotfi added reviewers: aaron.ballman, compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Removing a few of the entries in the Flags for the Types.def table. - Removing redundant parts of getCompilationPhases(). Repository: rG LLVM