This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL367313: [clangd] Fix a regression in rL366996. (authored by
hokein, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed
hokein marked 2 inline comments as done.
hokein added inline comments.
Comment at:
clang-tools-extra/clangd/refactor/tweaks/AnnotateHighlightings.cpp:43
+ if (!CommonDecl) {
+// Now we hit the TUDecl case where commonAncestor() returns null intently.
+// We only annotat
jvikstrom accepted this revision.
jvikstrom added inline comments.
This revision is now accepted and ready to land.
Comment at:
clang-tools-extra/clangd/refactor/tweaks/AnnotateHighlightings.cpp:43
+ if (!CommonDecl) {
+// Now we hit the TUDecl case where commonAncestor() r
hokein updated this revision to Diff 212329.
hokein added a comment.
oops, forgot a change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65443/new/
https://reviews.llvm.org/D65443
Files:
clang-tools-extra/clangd/refactor/tweaks/AnnotateHighligh
hokein created this revision.
hokein added a reviewer: jvikstrom.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.
That patch made the tweak always annotate the whole file by accident.
Repository:
rG LLVM Github Monorepo
https://rev
