[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL369253: [OpenCL] Add generic type handling for builtin functions (authored by svenvh, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65456/new/ https://reviews.llvm.org/D65456 ___ cfe-commits mailing

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

svenvh updated this revision to Diff 215086. svenvh marked 15 inline comments as done. svenvh added a comment. - Update comments as per review comments. - Rename iterator `List` to `VecSizes` in OpenCLBuiltins.td - Format GenericType definition. CHANGES SINCE LAST ACTION

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

svenvh added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:222 +// GenType definitions. +def FGenTypeN : GenericType<"FGenTypeN", TLFloat, VecAndScalar>; +// Generate basic GenTypes. Names are like: GenTypeFloatVecAndScalar. Anastasia wrote: >

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

Anastasia added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:222 +// GenType definitions. +def FGenTypeN : GenericType<"FGenTypeN", TLFloat, VecAndScalar>; +// Generate basic GenTypes. Names are like: GenTypeFloatVecAndScalar. svenvh wrote: >

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

svenvh marked 6 inline comments as done. svenvh added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:116 +// combination of Types and vector sizes. +// +// E.g.: If TypeListField = and VectorList = <1, 2, 4>, then Pierre wrote: > Maybe it would

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

svenvh updated this revision to Diff 214169. svenvh added a comment. - Move checking of GenType compatibility from SemaLookup to TableGen emitter. - Provide more elaborate explanation about combining GenTypes in a declaration. - Add `max`/`min` definitions to cover "sgentype" behavior and add

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

Pierre added a comment. Just one comment, Thank you again for making everything clearer :) Comment at: clang/lib/Sema/OpenCLBuiltins.td:116 +// combination of Types and vector sizes. +// +// E.g.: If TypeListField = and VectorList = <1, 2, 4>, then Maybe it

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

svenvh updated this revision to Diff 213904. svenvh marked 9 inline comments as done. svenvh added a comment. Addressing review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65456/new/ https://reviews.llvm.org/D65456 Files: clang/lib/Sema/OpenCLBuiltins.td

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

svenvh marked 23 inline comments as done. svenvh added a subscriber: Pierre. svenvh added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:51 -// Helper class to store type access qualifiers (volatile, const, ...). -class Qualifier { - string QualName = _QualName;

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

Anastasia added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:51 -// Helper class to store type access qualifiers (volatile, const, ...). -class Qualifier { - string QualName = _QualName; Are the qualifiers added elsewhere?

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

svenvh added a comment. Main changes since D63434 : - Rename List* to Vec*. - Rename TLnn -> TLAll, TLInt, TLFloat. - Apply clang-format. - Improve/update documentation. - Factor out renaming of base types into separate commit. - Change return type of OCL2Qual. -

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added subscribers: cfe-commits, kristina, yaxunl. Herald added a reviewer: rengolin. Herald added a project: clang. Generic types are an abstraction of type sets. It mimics the way functions are defined in the OpenCL