[PATCH] D6550: ASTImporter: Fix missing SourceLoc imports

This revision was automatically updated to reflect the committed changes. Closed by commit rC322079: [ASTImporter] Fix missing SourceLoc import for ObjCMethodDecl selectors (authored by a.sidorin, committed by ). Repository: rC Clang https://reviews.llvm.org/D6550 Files: lib/AST/ASTImporter

[PATCH] D6550: ASTImporter: Fix missing SourceLoc imports

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Great! Thanks! Repository: rC Clang https://reviews.llvm.org/D6550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D6550: ASTImporter: Fix missing SourceLoc imports

a.sidorin updated this revision to Diff 127375. a.sidorin added reviewers: xazax.hun, szepet. a.sidorin added a comment. Herald added a subscriber: rnkovacs. Removed already fixed stuff, added a test for remaining. Repository: rC Clang https://reviews.llvm.org/D6550 Files: lib/AST/ASTImpor

[PATCH] D6550: ASTImporter: Fix missing SourceLoc imports

a.sidorin added a comment. Thank you Sean, I'll try. https://reviews.llvm.org/D6550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D6550: ASTImporter: Fix missing SourceLoc imports

spyffe added a comment. Hmm, the transforming in place of `SelLocs` reads a little weirdly to me, but other than that the code seems fine. Is your concern that you don't know how to write an Objective-C test that would cover this? It looks to me like an Objective-C interface with a method: @

[PATCH] D6550: ASTImporter: Fix missing SourceLoc imports

a.sidorin added a comment. Will anybody object if I commit this change without a test? This bug seems to be pretty obvious but, unfortunately, I'm not familiar with Objective C. https://reviews.llvm.org/D6550 ___ cfe-commits mailing list cfe-commit

[PATCH] D6550: ASTImporter: Fix missing SourceLoc imports

a.sidorin added a comment. This patch lacks tests. If you add at least minimal test case (I'm not familiar with ObjC and its front-end, unfortunately), I will no have any concerns. Also adding Sean. https://reviews.llvm.org/D6550 ___ cfe-commits m

[PATCH] D6550: ASTImporter: Fix missing SourceLoc imports

xazax.hun added a comment. In https://reviews.llvm.org/D6550#663002, @a.sidorin wrote: > Hi Gabor. One of the bugs fixed in this patch is still present in master, > other two are already fixed. Thanks for checking that! Do you think it is ok for me to commit the missing part? https://review

[PATCH] D6550: ASTImporter: Fix missing SourceLoc imports

a.sidorin added a comment. Hi Gabor. One of the bugs fixed in this patch is still present in master, other two are already fixed. Comment at: lib/AST/ASTImporter.cpp:2749 // Create the imported function. + SourceLocation StartLoc = Importer.Import(D->getInnerLocStart());