[PATCH] D65853: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit

This revision was automatically updated to reflect the committed changes. Closed by commit rL368399: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65853: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit

lhames accepted this revision. lhames added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65853/new/ https://reviews.llvm.org/D65853

[PATCH] D65853: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit

gribozavr added a comment. In D65853#1619801 , @plotfi wrote: > I tested this out. Seems to work fine, and print the Expected's Error. I am > fine with it if @compnerd and @lhames and @jkorous are cool with it. @compnerd @lhames @jkorous ping?

[PATCH] D65853: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit

plotfi added a comment. plotfi@grendel:/mnt/nvme0/llvm-project$ build/tools/clang/unittests/DirectoryWatcher/./DirectoryWatcherTests --gtest_filter=DirectoryWatcherTest.AddFilesNote: Google Test filter = DirectoryWatcherTest.AddFiles [==] Running 1 test from 1 test case.

[PATCH] D65853: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit

plotfi added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65853/new/ https://reviews.llvm.org/D65853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D65853: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit

plotfi added a comment. I tested this out. Seems to work fine, and print the Expected's Error. I am fine with it if @compnerd and @lhames and @jkorous are cool with it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65853/new/

[PATCH] D65853: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit

gribozavr created this revision. gribozavr added reviewers: plotfi, jkorous, compnerd. Herald added subscribers: cfe-commits, dexonsmith, mgorny. Herald added a project: clang. ASSERT_THAT_ERROR looks like the intended helper for use in tests. Repository: rG LLVM Github Monorepo