This revision was automatically updated to reflect the committed changes.
Closed by commit rL368734: [NFC][clang] Adding argument based Phase list
filtering to getComplicationPhases (authored by zer0, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65993/new/
https://reviews.llvm.org/D65993
plotfi marked an inline comment as done.
plotfi added a comment.
@aaron.ballman How does this look to you?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65993/new/
https://reviews.llvm.org/D65993
___
plotfi marked 4 inline comments as done.
plotfi added inline comments.
Comment at: clang/include/clang/Driver/Types.h:107
+llvm::opt::DerivedArgList , ID Id,
+llvm::SmallVectorImpl );
compnerd wrote:
>
compnerd added inline comments.
Comment at: clang/include/clang/Driver/Types.h:107
+llvm::opt::DerivedArgList , ID Id,
+llvm::SmallVectorImpl );
This really makes things confusing, perhaps renaming
plotfi updated this revision to Diff 214541.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65993/new/
https://reviews.llvm.org/D65993
Files:
clang/include/clang/Driver/Types.h
clang/lib/Driver/Driver.cpp
clang/lib/Driver/Types.cpp
Index:
plotfi marked 5 inline comments as done.
plotfi added inline comments.
Comment at: clang/lib/Driver/Types.cpp:11
+#include "clang/Driver/Options.h"
+#include "clang/Driver/DriverDiagnostic.h"
#include "clang/Driver/Types.h"
aaron.ballman wrote:
> Can you sort
aaron.ballman added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:3326
+types::getCompilationPhases(*this, Args, InputType, PL);
+if (!PL.size())
continue;
`PL.empty()` instead
Comment at:
plotfi marked an inline comment as done.
plotfi added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:3220
- phases::ID FinalPhase;
{
Arg *FinalPhaseArg;
@aaron.ballman How's this look to you now? I have another NFC patch coming up
that will
plotfi updated this revision to Diff 214408.
plotfi added a comment.
using llvm::copy
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65993/new/
https://reviews.llvm.org/D65993
Files:
clang/include/clang/Driver/Types.h
plotfi marked an inline comment as done.
plotfi added inline comments.
Comment at: clang/lib/Driver/Types.cpp:313-315
+for (auto Phase : PhaseList)
+ if (Phase <= phases::Preprocess)
+P.push_back(Phase);
aaron.ballman wrote:
> How about:
>
>
plotfi added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:3220
- unsigned LastPLSize = 0;
- for (auto : Inputs) {
-types::ID InputType = I.first;
-const Arg *InputArg = I.second;
+ {
+Arg *FinalPhaseArg;
aaron.ballman wrote:
> Why
plotfi updated this revision to Diff 214403.
plotfi marked 2 inline comments as done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65993/new/
https://reviews.llvm.org/D65993
Files:
clang/include/clang/Driver/Types.h
clang/lib/Driver/Driver.cpp
aaron.ballman added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:3220
- unsigned LastPLSize = 0;
- for (auto : Inputs) {
-types::ID InputType = I.first;
-const Arg *InputArg = I.second;
+ {
+Arg *FinalPhaseArg;
Why do you need this
plotfi created this revision.
plotfi added reviewers: compnerd, aaron.ballman.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch removes usage of FinalPhase from anywhere outside of the scope where
it is used to do argument handling.
It also adds argument based
15 matches
Mail list logo
