[PATCH] D66211: [clangd][vscode] Surface the error when applying tweaks fails

This revision was automatically updated to reflect the committed changes. Closed by commit rL368851: [clangd][vscode] Surface the error when applying tweaks fails (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66211: [clangd][vscode] Surface the error when applying tweaks fails

hokein added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:109 +// Keep the default behavior. +if (error instanceof vscodelc.ResponseError && +error.code === vscodelc.ErrorCodes.RequestCancelled)

[PATCH] D66211: [clangd][vscode] Surface the error when applying tweaks fails

hokein updated this revision to Diff 215107. hokein marked an inline comment as done. hokein added a comment. avoid re-implementing of the method. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66211/new/ https://reviews.llvm.org/D66211 Files:

[PATCH] D66211: [clangd][vscode] Surface the error when applying tweaks fails

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Thanks for providing examples of error messages, also agree they look fine. If we find bad error messages later, we could revisit the presentation strategy. LGTM

[PATCH] D66211: [clangd][vscode] Surface the error when applying tweaks fails

hokein added a comment. In D66211#1629112 , @ilya-biryukov wrote: > How do they look in practice? In particular, should we add more context > information (either in clangd or in the VSCode extension) to those errors, > now that we know they are shown

[PATCH] D66211: [clangd][vscode] Surface the error when applying tweaks fails

ilya-biryukov added a comment. Surfacing errors to the users in those cases is definitely something we need to do, thanks! How do they look in practice? In particular, should we add more context information (either in clangd or in the VSCode extension) to those errors, now that we know they

[PATCH] D66211: [clangd][vscode] Surface the error when applying tweaks fails

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. The current behavior for a failed request is just to log it in the output panel. When applyTweak fails for whatever reason, users