[PATCH] D66219: [clangd] Added a colorizer to the vscode extension.

This revision was automatically updated to reflect the committed changes. jvikstrom marked 10 inline comments as done. Closed by commit rL369893: [clangd] Added a colorizer to the vscode extension. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscriber: llv

[PATCH] D66219: [clangd] Added a colorizer to the vscode extension.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, looks great, looking forward to use it, just a few more nits. Please update the patch description before committing. Comment at: clang-tools-extra/clangd/clients/cl

[PATCH] D66219: [clangd] Added a colorizer to the vscode extension.

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:135 + // Update the themeRuleMatcher that is used when highlighting. Also triggers a + // recolorization for all current highlighters. Safe to call multipl

[PATCH] D66219: [clangd] Added a colorizer to the vscode extension.

jvikstrom updated this revision to Diff 217099. jvikstrom marked 12 inline comments as done. jvikstrom added a comment. Made tests more readable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66219/new/ https://reviews.llvm.org/D66219 Files: cla

[PATCH] D66219: [clangd] Added a colorizer to the vscode extension.

hokein added a comment. thanks, looks better now. Some more comments on the test code. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:3 import * as vscodelc from 'vscode-languageclient'; - +import * as SM from './semantic-highlighting'; /** --

[PATCH] D66219: [clangd] Added a colorizer to the vscode extension.

jvikstrom updated this revision to Diff 216624. jvikstrom added a comment. Added missing protected and comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66219/new/ https://reviews.llvm.org/D66219 Files: clang-tools-extra/clangd/clients/clan

[PATCH] D66219: [clangd] Added a colorizer to the vscode extension.

jvikstrom added a comment. I had completely forgotten we could just override the applyHighlightings method in the tests, everything is much simpler now. Basically this entire CL was rewritten just now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D66219: [clangd] Added a colorizer to the vscode extension.

jvikstrom updated this revision to Diff 216621. jvikstrom marked 6 inline comments as done. jvikstrom added a comment. Rewrote the Highlighter class as we can override the highlighting method for the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D66219: [clangd] Added a colorizer to the vscode extension.

hokein added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:134 + // The decoration datatypes used last time highlight was called. + private oldDecorations: DecorationRangePair[] = []; + // Apply decorations to the tex

[PATCH] D66219: [clangd] Added a colorizer to the vscode extension.

jvikstrom updated this revision to Diff 215886. jvikstrom marked 4 inline comments as done. jvikstrom added a comment. Renamed colorizer to highlighter and added FIXME about highlightings below eof. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6621

[PATCH] D66219: [clangd] Added a colorizer to the vscode extension.

hokein added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:144 +// sends. +export class Colorizer { + private files: Map> = new Map(); The generic `T` doesnt seem to be used? Regarding the name, the w

[PATCH] D66219: [clangd] Added a colorizer to the vscode extension.

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Adds the main colorizer component. It colorizes every time clangd sends a publishSemanticHighlighting noti