[PATCH] D66240: Remove LVALUE / RVALUE workarounds

2019-08-14 Thread JF Bastien via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL368939: Remove LVALUE / RVALUE workarounds (authored by jfb, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D66240?vs=215202=215275#toc

[PATCH] D66240: Remove LVALUE / RVALUE workarounds

2019-08-14 Thread JF Bastien via Phabricator via cfe-commits
jfb added a comment. BTW, if this breaks stuff maybe it's better to do it one project at a time, and remove the helper at the very end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66240/new/ https://reviews.llvm.org/D66240

[PATCH] D66240: Remove LVALUE / RVALUE workarounds

2019-08-14 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66240/new/ https://reviews.llvm.org/D66240

[PATCH] D66240: Remove LVALUE / RVALUE workarounds

2019-08-14 Thread JF Bastien via Phabricator via cfe-commits
jfb created this revision. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, jkorous. Herald added projects: clang, LLVM. LLVM_HAS_RVALUE_REFERENCE_THIS and LLVM_LVALUE_FUNCTION shouldn't be needed anymore because the minimum compiler versions support them. Repository: rG LLVM