[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

This revision was automatically updated to reflect the committed changes. Closed by commit rL369604: [analyzer] TrackConstraintBRVisitor: Do not track unknown values (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Charusso added a comment. Thanks for the reviews! I hope that mentioned error will be visible by the `BugReporter` revisions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66267/new/ https://reviews.llvm.org/D66267 ___ cfe-commits mailing

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Szelethus accepted this revision. Szelethus added a comment. In D66267#1632344 , @Charusso wrote: > I would upstream my hotfix of nullability without any tests as the comment > says the intention and also we have plenty of tests of >

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Charusso updated this revision to Diff 215525. Charusso marked an inline comment as done. Charusso added a comment. - Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66267/new/ https://reviews.llvm.org/D66267 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1898-1900 + // If the contents are symbolic and null, find out when they became null. + if (V.getAsLocSymbol(/*IncludeBaseRegions=*/true)) +if

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Charusso marked an inline comment as done. Charusso added a comment. @Szelethus pointed out well. My patch is about nullability, and it is perfect. The bug report you made is about deduplication rather than nullability. The fact is we fail to call the deduplication function:

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Szelethus added a comment. In D66267#1632164 , @NoQ wrote: > In D66267#1630728 , @Szelethus wrote: > > > Shouldn't we just delete this entire visitor altogether and merge it into > > ConditionBRVisitor (like,

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

NoQ added a comment. In D66267#1630728 , @Szelethus wrote: > Shouldn't we just delete this entire visitor altogether and merge it into > ConditionBRVisitor (like, eventually, not right now)? It seems to be a relic > of the past. I'm actually curious

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. This code is super messy. It'd be great to actually test this change on something to see if it has any unwanted side effects. Could you see if it also fixes

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Szelethus added a comment. Shouldn't we just delete this entire visitor altogether and merge it into ConditionBRVisitor (like, eventually, not right now)? It seems to be a relic of the past. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66267/new/

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Charusso added a parent revision: D65889: [analyzer]