This revision was automatically updated to reflect the committed changes.
Closed by commit rL373442: [clangd] SelectionTree should mark a node as
fully-selected if the only claimed… (authored by sammccall, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
SureYeaah accepted this revision.
SureYeaah added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: usaxena95.
Sorry about the delay. LGTM. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66872/new/
sammccall updated this revision to Diff 218926.
sammccall added a comment.
remove special-case handling of VarDecl in ExtractFunction that is no longer
needed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66872/new/
sammccall updated this revision to Diff 217645.
sammccall added a comment.
remove printfs
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66872/new/
https://reviews.llvm.org/D66872
Files:
clang-tools-extra/clangd/Selection.cpp
sammccall created this revision.
sammccall added a reviewer: SureYeaah.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
Previously they would be marked as partially-selected based on the early claim,
and never updated as
