[PATCH] D66964: Sort Java imports without newline

2019-08-29 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Making the tests in this patch pass sounds good to me too :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66964/new/ https://reviews.llvm.org/D66964 ___ cfe-commits mailing

[PATCH] D66964: Sort Java imports without newline

2019-08-29 Thread Sam Maier via Phabricator via cfe-commits
SamMaier added a comment. In D66964#1651496 , @yannic wrote: > Right now, this change only adds a test that shows the broken behavior. > > SamMaier@ you're the author of https://reviews.llvm.org/D52800 which > implemented Java import sorting. Is there a

[PATCH] D66964: Sort Java imports without newline

2019-08-29 Thread Yannic Bonenberger via Phabricator via cfe-commits
yannic added reviewers: SamMaier, thakis. yannic added a comment. Right now, this change only adds a test that shows the broken behavior. SamMaier@ you're the author of https://reviews.llvm.org/D52800 which implemented Java import sorting. Is there a reason to not sort imports when there's

[PATCH] D66964: Sort Java imports without newline

2019-08-29 Thread Yannic Bonenberger via Phabricator via cfe-commits
yannic created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66964 Files: clang/unittests/Format/SortImportsTestJava.cpp Index: clang/unittests/Format/SortImportsTestJava.cpp