This revision was automatically updated to reflect the committed changes.
Closed by commit rGdd501045cdea: [Clang][Bundler] Error reporting improvements
(authored by sdmitriev).
Changed prior to commit:
https://reviews.llvm.org/D67031?vs=224726=226521#toc
Repository:
rG LLVM Github Monorepo
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67031/new/
https://reviews.llvm.org/D67031
___
cfe-commits mailing list
sdmitriev added inline comments.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:133
/// returned if there are no more bundles to be read.
- virtual StringRef ReadBundleStart(MemoryBuffer ) = 0;
+ virtual Expected>
+ ReadBundleStart(MemoryBuffer ) =
ABataev added inline comments.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:133
/// returned if there are no more bundles to be read.
- virtual StringRef ReadBundleStart(MemoryBuffer ) = 0;
+ virtual Expected>
+ ReadBundleStart(MemoryBuffer ) = 0;
sdmitriev added inline comments.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:133
/// returned if there are no more bundles to be read.
- virtual StringRef ReadBundleStart(MemoryBuffer ) = 0;
+ virtual Expected>
+ ReadBundleStart(MemoryBuffer ) =
sdmitriev updated this revision to Diff 224726.
sdmitriev added a comment.
Rebased patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67031/new/
https://reviews.llvm.org/D67031
Files:
clang/test/Driver/clang-offload-bundler.c
sdmitriev added inline comments.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:133
/// returned if there are no more bundles to be read.
- virtual StringRef ReadBundleStart(MemoryBuffer ) = 0;
+ virtual Expected>
+ ReadBundleStart(MemoryBuffer ) =
ABataev added inline comments.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:133
/// returned if there are no more bundles to be read.
- virtual StringRef ReadBundleStart(MemoryBuffer ) = 0;
+ virtual Expected>
+ ReadBundleStart(MemoryBuffer ) = 0;
sdmitriev added a comment.
Ping.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67031/new/
https://reviews.llvm.org/D67031
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdmitriev added a comment.
Ping.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67031/new/
https://reviews.llvm.org/D67031
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdmitriev added a comment.
Ping.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67031/new/
https://reviews.llvm.org/D67031
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdmitriev updated this revision to Diff 219742.
sdmitriev added a reviewer: Hahnfeld.
sdmitriev added a comment.
Rebase
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67031/new/
https://reviews.llvm.org/D67031
Files:
clang/test/Driver/clang-offload-bundler.c
sdmitriev added a comment.
Ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67031/new/
https://reviews.llvm.org/D67031
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdmitriev added a comment.
I think I have addressed all comments posted so far. Do you have more
notes/comments/suggestions?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67031/new/
https://reviews.llvm.org/D67031
___
cfe-commits mailing
sdmitriev marked an inline comment as done.
sdmitriev added inline comments.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44
-#include
-#include
-#include
-#include
Hahnfeld wrote:
> sdmitriev wrote:
> > Hahnfeld wrote:
> > >
sdmitriev updated this revision to Diff 218776.
sdmitriev edited the summary of this revision.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67031/new/
https://reviews.llvm.org/D67031
Files:
clang/test/Driver/clang-offload-bundler.c
Hahnfeld added inline comments.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44
-#include
-#include
-#include
-#include
sdmitriev wrote:
> Hahnfeld wrote:
> > sdmitriev wrote:
> > > Hahnfeld wrote:
> > > > sdmitriev wrote:
> > > >
sdmitriev marked an inline comment as done.
sdmitriev added inline comments.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44
-#include
-#include
-#include
-#include
Hahnfeld wrote:
> sdmitriev wrote:
> > Hahnfeld wrote:
> > >
Hahnfeld added a comment.
Also, there should be a summary of the changes in here.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44
-#include
-#include
-#include
-#include
sdmitriev wrote:
> Hahnfeld wrote:
> > sdmitriev wrote:
>
sdmitriev updated this revision to Diff 218755.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67031/new/
https://reviews.llvm.org/D67031
Files:
clang/test/Driver/clang-offload-bundler.c
clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp
Index:
sdmitriev marked an inline comment as done.
sdmitriev added inline comments.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44
-#include
-#include
-#include
-#include
Hahnfeld wrote:
> sdmitriev wrote:
> > Hahnfeld wrote:
> > > The
Hahnfeld added inline comments.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44
-#include
-#include
-#include
-#include
sdmitriev wrote:
> Hahnfeld wrote:
> > The code still uses (in the order of marked includes)
> > *
sdmitriev marked an inline comment as done.
sdmitriev added a comment.
Any comments?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67031/new/
https://reviews.llvm.org/D67031
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sdmitriev updated this revision to Diff 218250.
sdmitriev added a comment.
Removed trailing '.' from error messages and added few additional changes for
better error handling.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67031/new/
https://reviews.llvm.org/D67031
Files:
sdmitriev marked an inline comment as done.
sdmitriev added inline comments.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:906
+Msg << ", unknown target triple '" << Triple << "'";
+ reportError(createStringError(errc::invalid_argument,
MaskRay added inline comments.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:906
+Msg << ", unknown target triple '" << Triple << "'";
+ reportError(createStringError(errc::invalid_argument, Msg.str() + "."));
}
I think
sdmitriev marked an inline comment as done.
sdmitriev added inline comments.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44
-#include
-#include
-#include
-#include
Hahnfeld wrote:
> The code still uses (in the order of marked
sdmitriev updated this revision to Diff 218224.
sdmitriev retitled this revision from "[Clang][Bundler] Error reporting
improvements [NFC]" to "[Clang][Bundler] Error reporting improvements".
sdmitriev added a comment.
Addressed review comments.
CHANGES SINCE LAST ACTION
Hahnfeld added a comment.
This changes error messages, so I'd say it's not NFC.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44
-#include
-#include
-#include
-#include
The code still uses (in the order of marked includes)
*
sdmitriev created this revision.
sdmitriev added a reviewer: ABataev.
Herald added a reviewer: alexshap.
Herald added a reviewer: jdoerfert.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D67031
Files:
30 matches
Mail list logo
