This revision was automatically updated to reflect the committed changes.
Closed by commit rL371586: [CodeGen] Add alias for cpu_dispatch function with
IFunc Fix resolver linkageā¦ (authored by MaskRay, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
zsrkmyn marked 18 inline comments as done.
zsrkmyn added a comment.
All done IMO. :-)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67058/new/
https://reviews.llvm.org/D67058
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
zsrkmyn updated this revision to Diff 219568.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67058/new/
https://reviews.llvm.org/D67058
Files:
clang/lib/CodeGen/CodeGenModule.cpp
clang/test/CodeGen/attr-cpuspecific.c
clang/test/CodeGen/attr-target-mv-func-ptrs.c
erichkeane added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002
false);
llvm::Constant *Resolver = GetOrCreateLLVMFunction(
MangledName + ".resolver", ResolverType, GlobalDecl{},
zsrkmyn wrote:
> erichkeane wrote:
>
zsrkmyn added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002
false);
llvm::Constant *Resolver = GetOrCreateLLVMFunction(
MangledName + ".resolver", ResolverType, GlobalDecl{},
erichkeane wrote:
> zsrkmyn wrote:
> >
erichkeane added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002
false);
llvm::Constant *Resolver = GetOrCreateLLVMFunction(
MangledName + ".resolver", ResolverType, GlobalDecl{},
zsrkmyn wrote:
> erichkeane wrote:
>
zsrkmyn added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002
false);
llvm::Constant *Resolver = GetOrCreateLLVMFunction(
MangledName + ".resolver", ResolverType, GlobalDecl{},
erichkeane wrote:
> zsrkmyn wrote:
> >
erichkeane added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002
false);
llvm::Constant *Resolver = GetOrCreateLLVMFunction(
MangledName + ".resolver", ResolverType, GlobalDecl{},
zsrkmyn wrote:
> erichkeane wrote:
>
zsrkmyn added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002
false);
llvm::Constant *Resolver = GetOrCreateLLVMFunction(
MangledName + ".resolver", ResolverType, GlobalDecl{},
erichkeane wrote:
> zsrkmyn wrote:
> >
erichkeane added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002
false);
llvm::Constant *Resolver = GetOrCreateLLVMFunction(
MangledName + ".resolver", ResolverType, GlobalDecl{},
zsrkmyn wrote:
> zsrkmyn wrote:
> >
zsrkmyn marked an inline comment as done.
zsrkmyn added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002
false);
llvm::Constant *Resolver = GetOrCreateLLVMFunction(
MangledName + ".resolver", ResolverType, GlobalDecl{},
zsrkmyn marked an inline comment as done.
zsrkmyn added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002
false);
llvm::Constant *Resolver = GetOrCreateLLVMFunction(
MangledName + ".resolver", ResolverType, GlobalDecl{},
erichkeane added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002
false);
llvm::Constant *Resolver = GetOrCreateLLVMFunction(
MangledName + ".resolver", ResolverType, GlobalDecl{},
zsrkmyn wrote:
> erichkeane wrote:
>
zsrkmyn marked an inline comment as done.
zsrkmyn added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3005
/*ForVTable=*/false);
+auto Linkage = (FD->isCPUDispatchMultiVersion() ||
FD->isCPUSpecificMultiVersion())
+?
zsrkmyn added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002
false);
llvm::Constant *Resolver = GetOrCreateLLVMFunction(
MangledName + ".resolver", ResolverType, GlobalDecl{},
erichkeane wrote:
> This Resolver should
erichkeane added a comment.
Actually... I think it might need to be weak_odr based on
https://llvm.org/docs/LangRef.html#linkage-types
We want the merge semantics, but need to make sure that the symbols aren't
discarded.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67058/new/
erichkeane added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002
false);
llvm::Constant *Resolver = GetOrCreateLLVMFunction(
MangledName + ".resolver", ResolverType, GlobalDecl{},
This Resolver should have the same
zsrkmyn updated this revision to Diff 218830.
zsrkmyn retitled this revision from "[clang][CodeGen] Add alias for
cpu_dispatch function with IFunc" to "[clang][CodeGen] Add alias for
cpu_dispatch function with IFunc & Fix resolver linkage type".
CHANGES SINCE LAST ACTION
18 matches
Mail list logo