This revision was automatically updated to reflect the committed changes.
Closed by commit rL372078: [RISCV] Define __riscv_cmodel_medlow and
__riscv_cmodel_medany correctly (authored by kito, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to
lenary added a comment.
LGTM, now I've looked at how LLVM itself supports code models. I don't mind if
that TODO is or isn't deleted.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67065/new/
https://reviews.llvm.org/D67065
lenary added inline comments.
Comment at: clang/lib/Basic/Targets/RISCV.cpp:91
Builder.defineMacro("__riscv_xlen", Is64Bit ? "64" : "32");
// TODO: modify when more code models are supported.
+ StringRef CodeModel = getTargetOpts().CodeModel;
This TODO
lewis-revill accepted this revision.
lewis-revill added a comment.
This revision is now accepted and ready to land.
Thanks Kito. This looks good to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67065/new/
https://reviews.llvm.org/D67065
kito-cheng created this revision.
kito-cheng added reviewers: asb, apazos, lewis-revill.
Herald added subscribers: cfe-commits, pzheng, s.egerton, lenary, Jim, benna,
psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01,
edward-jones, zzheng, MaskRay, jrtc27, shiva0217,
