[PATCH] D67112: [Sema] Add implicit cast for conversion of function references

2020-02-26 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert reclaimed this revision. aaronpuchert removed a reviewer: riccibruno. aaronpuchert added a comment. The diff between both changes might still be interesting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67112/new/ https://reviews.llvm

[PATCH] D67112: [Sema] Add implicit cast for conversion of function references

2020-02-26 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert updated this revision to Diff 246862. aaronpuchert added a comment. Rebase on top of D66437 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67112/new/ https://reviews.llvm.org/D67112 Files: clang/inc

[PATCH] D67112: [Sema] Add implicit cast for conversion of function references

2019-12-05 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert abandoned this revision. aaronpuchert added a comment. Already fixed via D66437 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67112/new/ https://reviews.llvm.org/D67112

[PATCH] D67112: [Sema] Add implicit cast for conversion of function references

2019-10-08 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert planned changes to this revision. aaronpuchert added a comment. In D67112#1655937 , @aaronpuchert wrote: > If anyone shares my feeling that the boolean output parameters of > `CompareReferenceRelationship` should rather move to the return va

[PATCH] D67112: [Sema] Add implicit cast for conversion of function references

2019-09-21 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a reviewer: riccibruno. aaronpuchert added a comment. Perhaps I should mention that this fixes an assertion failure . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67112/new/ https://

[PATCH] D67112: [Sema] Add implicit cast for conversion of function references

2019-09-03 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert created this revision. aaronpuchert added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. aaronpuchert marked 2 inline comments as done. aaronpuchert added a comment. If anyone shares my feeling that the boolean output parameters of `Compare

[PATCH] D67112: [Sema] Add implicit cast for conversion of function references

2019-09-03 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert marked 2 inline comments as done. aaronpuchert added a comment. If anyone shares my feeling that the boolean output parameters of `CompareReferenceRelationship` should rather move to the return value, I would be happy to do that. Comment at: clang/test/CXX/dcl.de