[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

simon_tatham abandoned this revision. simon_tatham added a comment. I ended up solving this problem a completely different way, in D72518 . Instead of controlling the behavior I need based on the target architecture, I made it depend on a type attribute on the

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

simon_tatham added a comment. (The draft implementations of `vsetq_lane` are now in D70133 .) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67160/new/ https://reviews.llvm.org/D67160

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

simon_tatham added a comment. In D67160#1704840 , @rsmith wrote: > If overload resolution can't distinguish between overloads that perform a lax > vector conversions and those that do not, we should fix that in overload > resolution rather than papering

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

simon_tatham added a comment. Hmmm. I take your point, and so I backed out my local version of this patch in order to try to solve the problem a different way in overload resolution. But in fact overloading on different vector types already seems to work fine: my in-progress patch series still

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. It is not reasonable to make this change on a per-target basis. We should work towards turning lax vector conversions off globally instead. If overload resolution can't distinguish

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

dmgreen added a subscriber: rsmith. dmgreen accepted this revision. dmgreen added a comment. Yeah, OK. D67678 is the patch that will change the default, but only to "int", not to "none" for the moment. An earlier version of that patch had a different way of

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

simon_tatham added a comment. Yes, the commit message in rL371817 mentions that the long-term aim is to change the default to `none` for everyone. If that change happens before I manage to land this patch, then this patch certainly will become unnecessary.

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

dmgreen added a comment. Yes.. My understanding is that the default is still -flax-vector-convertions=all (the old clang behaviour), but the plan is to change it (for all architectures) to none. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

kristof.beyls added a comment. Would it still make sense to have this patch after D68683 lands? At first sight, it seems this patch might no longer make sense then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

simon_tatham updated this revision to Diff 224031. simon_tatham added a comment. Rebased to current master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67160/new/ https://reviews.llvm.org/D67160 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

dmgreen added a comment. FYI: rL371817 , in case it changes what is done here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67160/new/ https://reviews.llvm.org/D67160

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67160/new/ https://reviews.llvm.org/D67160

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

simon_tatham updated this revision to Diff 219692. simon_tatham added a comment. Added a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67160/new/ https://reviews.llvm.org/D67160 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

ostannard requested changes to this revision. ostannard added a comment. This revision now requires changes to proceed. Test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67160/new/ https://reviews.llvm.org/D67160

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, miyuki, ostannard. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. The ACLE intrinsics for the MVE instruction set have polymorphic variants: you can write vaddq(v,w) and