This revision was automatically updated to reflect the committed changes.
Closed by commit rL371659: [analyzer] NFC: Move getStmt() and createEndOfPath()
out of PathDiagnostic. (authored by dergachev, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed
NoQ marked 2 inline comments as done.
NoQ added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/ExplodedGraph.cpp:302-303
// Find the node's current statement in the CFG.
- if (const Stmt *S = PathDiagnosticLocation::getStmt(this))
+ // FIXME:
NoQ marked an inline comment as done.
NoQ added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2185
} else {
-assert(ErrorNode);
-hash.AddPointer(GetCurrentOrPreviousStmt(ErrorNode));
NoQ wrote:
> Szelethus wrote:
> > Why
NoQ marked an inline comment as done.
NoQ added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2185
} else {
-assert(ErrorNode);
-hash.AddPointer(GetCurrentOrPreviousStmt(ErrorNode));
Szelethus wrote:
> Why delete the
Szelethus accepted this revision.
Szelethus added a comment.
This revision is now accepted and ready to land.
LGTM! I think code readability improved geatly.
> This creates a certain problem in `RetainCountChecker` (surprise!!~)
We constantly bully this checker, but still not enough :^)
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus,
baloghadamsoftware, Charusso.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho,
a.sidorin, zzheng, szepet, kristof.beyls.
Herald added a project: clang.
These static
